-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): [Bambora APAC] Add payment flows #5193
Conversation
status: enums::AttemptStatus::Charged, | ||
response: Ok(types::PaymentsResponseData::TransactionResponse { | ||
resource_id: types::ResponseId::ConnectorTransactionId( | ||
connector_transaction_id.to_owned(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are over-riding the authorize transaction id to capture_transaction_id, and losing the context of first_id completely. Is this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will not be able to recover the payment_status if timeout happens in capture call
Type of Change
Description
Added flows for bambora apac
Payment method added: Card (Non-3DS only)
Payment Flows added: Authorize, Psync, Refund, Rsync , Capture(Single Capture only)
Additional Changes
Motivation and Context
How did you test it?
Tested through Postman:
succeeded
Checklist
cargo +nightly fmt --all
cargo clippy