Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logging): Emit a setup error when a restricted keys are used for logging default keys #5185

Merged
merged 16 commits into from
Jul 14, 2024
Merged

feat(logging): Emit a setup error when a restricted keys are used for logging default keys #5185

merged 16 commits into from
Jul 14, 2024

Conversation

Abhitator216
Copy link
Contributor

@Abhitator216 Abhitator216 commented Jul 3, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Emit a setup error when a restricted keys are used for logging default keys

How did you test it?

Enable the level = "TRACE" and log_format = "pretty_json" in development.toml and cargo run it will show the logs

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Abhitator216 Abhitator216 requested review from a team as code owners July 3, 2024 08:46
@Abhitator216 Abhitator216 linked an issue Jul 3, 2024 that may be closed by this pull request
enhancement(logging): Emit a setup error when a restricted keys are used for logging default keys #5025
Closed
@Abhitator216 Abhitator216 changed the title Enhancement/logging restricted keys 5025 feat(logging): restricted keys 5025 Jul 3, 2024
lsampras
lsampras previously approved these changes Jul 3, 2024
View reviewed changes
@Abhitator216 Abhitator216 requested a review from tsdk02 July 3, 2024 10:12
tsdk02
tsdk02 previously approved these changes Jul 3, 2024
View reviewed changes
@Abhitator216 Abhitator216 dismissed stale reviews from tsdk02 and lsampras via c634230 July 4, 2024 11:52
tsdk02
tsdk02 previously approved these changes Jul 4, 2024
View reviewed changes
lsampras
lsampras previously approved these changes Jul 4, 2024
View reviewed changes
SanchithHegde
SanchithHegde reviewed Jul 7, 2024
View reviewed changes
crates/common_enums/Cargo.toml Outdated Show resolved Hide resolved
crates/common_enums/Cargo.toml Outdated Show resolved Hide resolved
crates/common_enums/src/enums.rs Outdated Show resolved Hide resolved
crates/common_enums/src/enums.rs Outdated Show resolved Hide resolved
crates/router/src/configs/settings.rs Outdated Show resolved Hide resolved
crates/router_env/src/logger/formatter.rs Outdated Show resolved Hide resolved
@SanchithHegde SanchithHegde added A-framework Area: Framework S-waiting-on-author Status: This PR is incomplete or needs to address review comments C-refactor Category: Refactor A-errors Area: error messages, structure & logging labels Jul 7, 2024
@Abhitator216 Abhitator216 changed the title feat(logging): restricted keys 5025 feat(logging): Emit a setup error when a restricted keys are used for logging default keys Jul 11, 2024
@Abhitator216 Abhitator216 changed the title feat(logging): Emit a setup error when a restricted keys are used for logging default keys feat(logging): Emit a setup error when a restricted keys are used for logging default key Jul 11, 2024
@Abhitator216 Abhitator216 changed the title feat(logging): Emit a setup error when a restricted keys are used for logging default key feat(logging): Emit a setup error when a restricted keys are used for logging default keys Jul 11, 2024
SanchithHegde
SanchithHegde previously approved these changes Jul 11, 2024
View reviewed changes
@Abhitator216 Abhitator216 requested a review from a team as a code owner July 11, 2024 11:11
tsdk02
tsdk02 previously approved these changes Jul 12, 2024
View reviewed changes
@SanchithHegde SanchithHegde added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jul 14, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jul 14, 2024
Merged via the queue into main with commit ff96a62 Jul 14, 2024
13 checks passed
@Gnanasundari24 Gnanasundari24 deleted the enhancement/logging-restricted-keys-5025 branch July 14, 2024 14:18
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 14, 2024
pixincreate added a commit that referenced this pull request Jul 16, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into add-cypress-ci
0fab196 
* 'main' of github.com:juspay/hyperswitch: (25 commits)
  fix(logs): ignore request headers while logging (#5273)
  feat(webhooks): add support for custom outgoing webhook http headers (#5275)
  fix(payment_methods): set `requires_cvv` to false when either `connector_mandate_details` or `network_transaction_id` is present during MITs (#5331)
  chore: create justfile for running commands for v1 and v2 migrations (#5325)
  fix(routing): do not update `perform_session_flow_routing` output if the `SessionRoutingChoice` is none (#5336)
  fix(database): modified_at updated for every state change for Payment Attempts (#5312)
  feat(mca): Added recipient connector call for open banking connectors (#3758)
  chore(version): 2024.07.16.0
  refactor(connector): [Mifinity] add a field language_preference in payment request for mifinity payment method data (#5326)
  fix(router): store `customer_acceptance` in payment_attempt, use it in confirm flow for delayed authorizations like external 3ds flow (#5308)
  feat(proxy): add support to pass proxy bypass urls from configs (#5322)
  Docs: Updating Error codes in API-ref (#5296)
  feat(core): [Payouts] Add retrieve flow for payouts (#4936)
  fix(connector): [AUTHORIZEDOTNET] Populate error reason for failure transactions (#5319)
  chore(version): 2024.07.15.0
  feat(logging): Emit a setup error when a restricted keys are used for logging default keys (#5185)
  feat(payment_methods): add support to migrate existing customer PMs from processor to hyperswitch (#5306)
  feat(connector): [DATATRANS] Implement card payments (#5028)
  chore: making of function create_encrypted_data (#5251)
  fix(payments): populate merchant order ref id in list (#5310)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShankarSinghC ShankarSinghC ShankarSinghC approved these changes

@tsdk02 tsdk02 tsdk02 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@lsampras lsampras lsampras approved these changes

@Gnanasundari24 Gnanasundari24 Awaiting requested review from Gnanasundari24

Assignees

@Abhitator216 Abhitator216

Labels
A-errors Area: error messages, structure & logging A-framework Area: Framework C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhancement(logging): Emit a setup error when a restricted keys are used for logging default keys
7 participants
@Abhitator216 @lsampras @SanchithHegde @tsdk02 @ShankarSinghC @pixincreate @Gnanasundari24