feat(decision): add support to register api keys to proxy #5168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshay-97
reviewed
Jul 1, 2024
| } | ||
| } | ||
|
|
||
| pub async fn add_publishable_key( |
There was a problem hiding this comment.
should we combine with add_api_key and pass variant to a common function ?
akshay-97
reviewed
Jul 1, 2024
| @@ -281,6 +281,25 @@ pub async fn create_merchant_account( | |||
| .await | |||
| .to_duplicate_response(errors::ApiErrorResponse::DuplicateMerchantAccount)?; | |||
|
|
|||
| if let Some(api_key) = merchant_account.publishable_key.as_ref() { | |||
| let state = state.clone(); | |||
There was a problem hiding this comment.
should we clone only necessary data here?
There was a problem hiding this comment.
NishantJoshi00
commented
Jul 1, 2024
|
|
||
| let response = state | ||
| .api_client | ||
| .send_request(state, request, None, false) |
There was a problem hiding this comment.
@akshay-97 , we cannot pass standalone ApiClient as the send_request function takes SessionState as an input argument
akshay-97
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds support for exporting hashed api keys to the incoming proxy allowing for authentication outside the application facilitating detached authentication and ratelimiting
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy