-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(connectors): [Iatapay] add payment methods #4968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
crates/api_models/src/payments.rs
Outdated
Fps { | ||
/// The two-letter ISO country code for SEPA and BACS | ||
#[schema(value_type = CountryAlpha2, example = "US")] | ||
country: Option<api_enums::CountryAlpha2>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not required as we are already collecting payment_method_data.billing details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed country from all real time payment methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Routing related changes LGTM
api_models::enums::PaymentMethod::RealTimePayment => { | ||
if let Some(payment_method_types) = methods.payment_method_types { | ||
for method_type in payment_method_types { | ||
reward_details.push(Provider { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be real_time_payment_details right?
ea25f9a
Co-authored-by: SamraatBansal <[email protected]>
…outs * 'main' of github.com:juspay/hyperswitch: feat(router): include the pre-routing connectors in Apple Pay retries (#4952) fix(cypress): Add `jwt_token` and `cookie` for routing test (#4953) feat(connectors): [Iatapay] add payment methods (#4968) chore(version): 2024.06.13.0 feat(payouts): make payout_type optional in payouts table (#4954) feat(connector): [BOA/CYB] Make billTo fields optional (#4951) fix(core): fix the multitenancy prefix in routing cache (#4963) refactor(connector): [Mifinity]Move destination_account_number from pmd to Mifinity Metadata (#4962) refactor(payment_methods): Enable deletion of default Payment Methods (#4942)
Type of Change
Description
This PR
Additional Changes
How did you test it?
Note: Test it through stripe compatibility layer
Response
Response
Response
Response
Response
Response
on psync Response
Checklist
cargo +nightly fmt --all
cargo clippy