refactor(core): move router data response and request models to hyperswitch domain models crate #4789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…switch domain models crate
hrithikesh026
added
S-waiting-on-review
Narayanbhat166
approved these changes
May 28, 2024
| @@ -1140,8 +746,8 @@ impl Tokenizable for CompleteAuthorizeData { | |||
| fn set_session_token(&mut self, _token: Option<String>) {} | |||
| } | |||
|
|
|||
| impl From<&SetupMandateRouterData> for PaymentsAuthorizeData { | |||
| fn from(data: &SetupMandateRouterData) -> Self { | |||
| impl ForeignFrom<&SetupMandateRouterData> for PaymentsAuthorizeData { | |||
There was a problem hiding this comment.
I see that other try from's are moved to domain models, should this be also moved?
There was a problem hiding this comment.
Since SetupMandateRouterData is defined in router crate, I couldn't move this From implementation to domain_models crate, Once we move all the RouterData aliases to domain_models crate, we can move these From implementation as well.
SanchithHegde
approved these changes
May 28, 2024
likhinbopanna
removed
the
S-waiting-on-review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
likhinbopanna
deleted the
move-router-data-response-models-to-hyperswitch-domain-model
branch
ghost
pushed a commit
that referenced
this pull request
May 29, 2024
…actor * 'main' of github.com:juspay/hyperswitch: (39 commits) Fix(Cypress): Fixing 3DS payment failure in headless mode (#4807) feat(users): Add redis in Begin and Verify TOTP and create a new API that updates TOTP (#4765) refactor(connector): [Klarna] Refactor Authorize call and configs for prod (#4750) fix: implement StrongEq for Vec<u8> (#4795) refactor(core): move router data response and request models to hyperswitch domain models crate (#4789) chore(version): 2024.05.29.0 refactor: retrieve extended card info config during business profile get call (#4784) refactor(payment_methods): add support for passing ttl to locker entries (#4690) feat(connector): [CRYPTOPAY] Pass network details in payment request (#4779) fix: include client columns in payment attempts response struct (#4761) fix(docker-compose): fix docker compose syntax (#4782) feat(connector): [Iatapay] add upi qr support (#4728) docs(analytics): Add documentation for setting up data services and enabling data features in control center (#4741) chore(version): 2024.05.28.0 feat(connector): [AUTHORIZEDOTNET] Implement non-zero mandates (#4758) feat(core): [Paypal] Add session_token flow for Paypal sdk (#4697) chore(version): 2024.05.27.0 chore: add missing migrations for recently added currencies (#4760) Refactor(core): Inclusion of constraint graph for merchant Payment Method list (#4626) chore(version): 2024.05.24.1 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Moved all router_data response models and a few request models to hyperswitch domain models crate.
Additional Changes
Motivation and Context
How did you test it?
Checked if the code compiles successfully.
Checklist
cargo +nightly fmt --allcargo clippy