-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(connector): [NMI] External 3DS flow for Cards #4385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
email: item.email.clone(), | ||
cavv: Some(auth_data.cavv.clone()), | ||
eci: auth_data.eci.clone(), | ||
xid: None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please populate xid with threeds_server_transaction_id and three_ds_version with message_version here
sai-harsha-vardhan
approved these changes
Apr 18, 2024
xid: Some(auth_data.threeds_server_transaction_id.clone()), | ||
cardholder_auth: None, | ||
three_ds_version: Some(auth_data.message_version.clone()), | ||
directory_server_id: None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please create an issue for missing values here
srujanchikke
approved these changes
Apr 18, 2024
pixincreate
added a commit
that referenced
this pull request
Apr 18, 2024
…press-for-more-control * 'main' of github.com:juspay/hyperswitch: feat(payments): add amount and connector id filter in list (#4354) feat(connector): [NMI] External 3DS flow for Cards (#4385) test(cypress): Update ConnectorAuth Details (#4386) chore(version): 2024.04.18.0 fix(router): make payment_instrument optional (#4389) fix(config): remove `merchant_business_country` from the connector configs as enums can not be handled in this toml file (#4383) feat(payment_link): Add support for saved payment method option for payment link (#4373)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-connector-integration
Area: Connector integration
C-feature
Category: Feature request or enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
External 3DS is done through ThreeDSecure.io for Card payment in NMI
Additional Changes
Motivation and Context
How did you test it?
Tested through Postman:
three_ds_method_data
from the response:Fill the threeDSMethodData field with collected three_ds_method_data
succeeded
Checklist
cargo +nightly fmt --all
cargo clippy