refactor(connector): pass optional browser_info to stripe for increased trust #4374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-connector-integration
hrithikesh026
previously approved these changes
Apr 17, 2024
hrithikesh026
previously approved these changes
Apr 18, 2024
srujanchikke
previously approved these changes
Apr 22, 2024
pixincreate
dismissed stale reviews from srujanchikke and hrithikesh026
via
b7f7258
pixincreate
requested review from
srujanchikke,
hrithikesh026 and
Narayanbhat166
Narayanbhat166
previously approved these changes
Apr 23, 2024
Narayanbhat166
approved these changes
Apr 23, 2024
hrithikesh026
approved these changes
Apr 23, 2024
srujanchikke
approved these changes
Apr 23, 2024
pixincreate
added
S-waiting-on-approval
likhinbopanna
removed
the
S-waiting-on-approval
pixincreate
added a commit
that referenced
this pull request
Apr 25, 2024
…to-env * 'main' of github.com:juspay/hyperswitch: ci(postman): Fix Adyen postman collection (#4459) docs(cypress): Update Cypress README Documentation (#4380) Refactor(core): make save_payment_method as post_update_tracker trait function (#4307) refactor(connector): pass optional browser_info to stripe for increased trust (#4374)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds optional
browser_infowhere we pass theuser_agentandip_addressin the name of added security for increasing trust as recommended here in their docs.Additional Changes
Motivation and Context
This changes helps increase trust in the transactions done and reduce fraudulent transactions.
How did you test it?
Tested locally.
For a Payment made that has
browser_infopassed, we're passingip_addressanduser_agentinfo to the connectorNormal Payments
{ "payment_id": "pay_C8c3HZPT8gI7XsTFqT7D", "merchant_id": "postman_merchant_GHAction_523bcf6e-5b18-4f35-9b59-e2edf85b8fc4", "status": "succeeded", "amount": 4545, "net_amount": 4545, "amount_capturable": 0, "amount_received": 4545, "connector": "stripe", "client_secret": "pay_C8c3HZPT8gI7XsTFqT7D_secret_lU1l8eCIRDwFpqN74ZjV", "created": "2024-04-16T11:55:40.769Z", "currency": "USD", "customer_id": "StripeCustomer", "customer": { "id": "StripeCustomer", "name": "Lapak Landu", "email": "[email protected]", "phone": "4444999966", "phone_country_code": "+1" }, "description": "Its my last payment request", "refunds": null, "disputes": null, "mandate_id": null, "mandate_data": null, "setup_future_usage": null, "off_session": null, "capture_on": null, "capture_method": "automatic", "payment_method": "card", "payment_method_data": { "card": { "last4": "4242", "card_type": null, "card_network": null, "card_issuer": null, "card_issuing_country": null, "card_isin": "424242", "card_extended_bin": "42424242", "card_exp_month": "10", "card_exp_year": "25", "card_holder_name": "Lapak Landu Doe", "payment_checks": { "address_line1_check": "pass", "address_postal_code_check": "pass", "cvc_check": "pass" }, "authentication_data": null }, "billing": null }, "payment_token": null, "shipping": null, "billing": { "address": { "city": "San Fransico", "country": "US", "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "zip": "560001", "state": "California", "first_name": "PiX", "last_name": null }, "phone": null, "email": null }, "order_details": null, "email": "[email protected]", "name": "Lapak Landu", "phone": "4444999966", "return_url": "https://duck.com/", "authentication_type": "no_three_ds", "statement_descriptor_name": "PiX", "statement_descriptor_suffix": "JS", "next_action": null, "cancellation_reason": null, "error_code": null, "error_message": null, "unified_code": null, "unified_message": null, "payment_experience": null, "payment_method_type": null, "connector_label": null, "business_country": null, "business_label": "default", "business_sub_label": null, "allowed_payment_method_types": null, "ephemeral_key": { "customer_id": "StripeCustomer", "created_at": 1713268540, "expires": 1713272140, "secret": "epk_f46f28dd49344d598914ea6c20c66fee" }, "manual_retry_allowed": false, "connector_transaction_id": "pi_3P6AbxD5R7gDAGff0vnaupsb", "frm_message": null, "metadata": { "udf1": "value1", "login_date": "2019-09-10T10:11:12Z", "new_customer": "true" }, "connector_metadata": null, "feature_metadata": null, "reference_id": "pi_3P6AbxD5R7gDAGff0vnaupsb", "payment_link": null, "profile_id": "pro_3ywCNBHIQH1mKTMvRQdq", "surcharge_details": null, "attempt_count": 1, "merchant_decision": null, "merchant_connector_id": "mca_tZB5c7C6gJ60euyAq6Zy", "incremental_authorization_allowed": null, "authorization_count": null, "incremental_authorizations": null, "external_authentication_details": null, "external_3ds_authentication_attempted": false, "expires_on": "2024-04-16T12:10:40.769Z", "fingerprint": null, "browser_info": { "ip_address": "62.132.141.1", "user_agent": "Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)" }, "payment_method_id": null, "payment_method_status": null, "updated": "2024-04-16T11:55:42.575Z" }Logs:
Sent info can also be verified in the Stripe dashboard under
request_parameters:Mandate Payments
Setup Mandate
{ "payment_id": "pay_y2sN9MmJcD5EQW4hOEAD", "merchant_id": "postman_merchant_GHAction_1ae79909-5aa3-47ec-b90b-254f423247aa", "status": "succeeded", "amount": 0, "net_amount": 0, "amount_capturable": 0, "amount_received": null, "connector": "stripe", "client_secret": "pay_y2sN9MmJcD5EQW4hOEAD_secret_yD5rGoVcTH58lNekPDL7", "created": "2024-04-18T07:15:45.604Z", "currency": "USD", "customer_id": "StripeCustomer", "customer": { "id": "StripeCustomer", "name": "John Doe", "email": "[email protected]", "phone": "999999999", "phone_country_code": "+65" }, "description": "Its my first payment request", "refunds": null, "disputes": null, "mandate_id": "man_QuAFrbLieIFMeZg0i2ym", "mandate_data": { "update_mandate_id": null, "customer_acceptance": { "acceptance_type": "offline", "accepted_at": "1963-05-03T04:07:52.723Z", "online": { "ip_address": "127.0.0.1", "user_agent": "amet irure esse" } }, "mandate_type": { "single_use": { "amount": 7000, "currency": "USD", "start_date": null, "end_date": null, "metadata": null } } }, "setup_future_usage": "off_session", "off_session": null, "capture_on": null, "capture_method": "automatic", "payment_method": "card", "payment_method_data": { "card": { "last4": "4242", "card_type": null, "card_network": null, "card_issuer": null, "card_issuing_country": null, "card_isin": "424242", "card_extended_bin": "42424242", "card_exp_month": "10", "card_exp_year": "25", "card_holder_name": "joseph Doe", "payment_checks": { "address_line1_check": null, "address_postal_code_check": null, "cvc_check": "pass" }, "authentication_data": null }, "billing": null }, "payment_token": null, "shipping": { "address": { "city": "San Fransico", "country": "US", "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "zip": "94122", "state": "California", "first_name": "sundari", "last_name": null }, "phone": null, "email": null }, "billing": null, "order_details": null, "email": "[email protected]", "name": "John Doe", "phone": "999999999", "return_url": "https://duck.com/", "authentication_type": "no_three_ds", "statement_descriptor_name": "joseph", "statement_descriptor_suffix": "JS", "next_action": null, "cancellation_reason": null, "error_code": null, "error_message": null, "unified_code": null, "unified_message": null, "payment_experience": null, "payment_method_type": null, "connector_label": null, "business_country": null, "business_label": "default", "business_sub_label": null, "allowed_payment_method_types": null, "ephemeral_key": { "customer_id": "StripeCustomer", "created_at": 1713424545, "expires": 1713428145, "secret": "epk_7b1a12da04f6456dae7fa9f2eb43e6f9" }, "manual_retry_allowed": false, "connector_transaction_id": "seti_1P6pCBD5R7gDAGffyXxXitZc", "frm_message": null, "metadata": { "udf1": "value1", "login_date": "2019-09-10T10:11:12Z", "new_customer": "true" }, "connector_metadata": null, "feature_metadata": null, "reference_id": "seti_1P6pCBD5R7gDAGffyXxXitZc", "payment_link": null, "profile_id": "pro_7U7w3bCXXYoJdwRW6IXu", "surcharge_details": null, "attempt_count": 1, "merchant_decision": null, "merchant_connector_id": "mca_76OuI3JqbGJTnxYz07Dq", "incremental_authorization_allowed": null, "authorization_count": null, "incremental_authorizations": null, "external_authentication_details": null, "external_3ds_authentication_attempted": false, "expires_on": "2024-04-18T07:30:45.604Z", "fingerprint": null, "browser_info": { "ip_address": "192.168.0.1", "user_agent": "Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)" }, "payment_method_id": "pm_g5bq9Pcnivwq3wJJtdec", "payment_method_status": null, "updated": "2024-04-18T07:15:48.132Z" }Logs:
In recurring payments, you're cannot pass
browser_information, hence we passnull{ "payment_id": "pay_HkPJoJftfFkgZ8fxQqAa", "merchant_id": "postman_merchant_GHAction_26cb565f-989d-4842-9204-433b34cb4137", "status": "succeeded", "amount": 6570, "net_amount": 6570, "amount_capturable": 0, "amount_received": 6570, "connector": "stripe", "client_secret": "pay_HkPJoJftfFkgZ8fxQqAa_secret_SU3Xfm6Abq2BMKNs1let", "created": "2024-04-18T08:28:10.043Z", "currency": "USD", "customer_id": "StripeCustomer", "customer": { "id": "StripeCustomer", "name": "John Doe", "email": "[email protected]", "phone": "999999999", "phone_country_code": "+65" }, "description": "Its my first payment request", "refunds": null, "disputes": null, "mandate_id": "man_TySHZjkoArkztQXZGnAt", "mandate_data": null, "setup_future_usage": null, "off_session": null, "capture_on": null, "capture_method": "automatic", "payment_method": "card", "payment_method_data": null, "payment_token": "be7040da-0ddb-46e5-889a-f18b03bf89d1", "shipping": { "address": { "city": "San Fransico", "country": "US", "line1": "1467", "line2": "Harrison Street", "line3": "Harrison Street", "zip": "94122", "state": "California", "first_name": "sundari", "last_name": null }, "phone": null, "email": null }, "billing": null, "order_details": null, "email": "[email protected]", "name": "John Doe", "phone": "999999999", "return_url": "https://duck.com/", "authentication_type": "no_three_ds", "statement_descriptor_name": "joseph", "statement_descriptor_suffix": "JS", "next_action": null, "cancellation_reason": null, "error_code": null, "error_message": null, "unified_code": null, "unified_message": null, "payment_experience": null, "payment_method_type": null, "connector_label": null, "business_country": null, "business_label": "default", "business_sub_label": null, "allowed_payment_method_types": null, "ephemeral_key": { "customer_id": "StripeCustomer", "created_at": 1713428889, "expires": 1713432489, "secret": "epk_d8bcb9d19df0497b90ef477eef8aaf29" }, "manual_retry_allowed": false, "connector_transaction_id": "pi_3P6qKED5R7gDAGff10wwV37R", "frm_message": null, "metadata": { "udf1": "value1", "login_date": "2019-09-10T10:11:12Z", "new_customer": "true" }, "connector_metadata": null, "feature_metadata": null, "reference_id": "pi_3P6qKED5R7gDAGff10wwV37R", "payment_link": null, "profile_id": "pro_MSBOS0KaCvwB2BWENrTg", "surcharge_details": null, "attempt_count": 1, "merchant_decision": null, "merchant_connector_id": "mca_Lc3wxpuLCVY5AdYBDiwp", "incremental_authorization_allowed": null, "authorization_count": null, "incremental_authorizations": null, "external_authentication_details": null, "external_3ds_authentication_attempted": false, "expires_on": "2024-04-18T08:43:10.043Z", "fingerprint": null, "browser_info": { "ip_address": "192.168.0.1", "user_agent": "Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)" }, "payment_method_id": null, "payment_method_status": null, "updated": "2024-04-18T08:28:11.600Z" }Logs:
Ran postman tests for regressions
Even if you pass entire supported
browser_info, onlyip_addressanduser_agentis sent to StripeChecklist
cargo +nightly fmt --allcargo clippy