Skip to content

fix(core): fix recurring mandates flow for cyber source #3224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 3, 2024
Merged

fix(core): fix recurring mandates flow for cyber source #3224

merged 4 commits into from
Jan 3, 2024

Conversation

Aprabhat19
Copy link
Contributor

@Aprabhat19 Aprabhat19 commented Jan 2, 2024 •
edited by SamraatBansal
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • [fix]: Recurring Payments via Wallets
  • [feat]: Implement zero dollar mandates and recurring payments via wallets
  • [refactor]: Update the mandate token created with cybersource from instrumentIdentifier to PaymentInstrument

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  • Create a Merchant and an Mca for cyberource
  • Make a setup mandate payment for card and also for wallet
  • Make a recurring mandate payment for card and also google_pay
  • The payment should succeed
  • Test both zero and non-zero mandate creation
Screenshot 2024-01-03 at 4 50 42 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Aprabhat19 Aprabhat19 added A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 2, 2024
@Aprabhat19 Aprabhat19 self-assigned this Jan 2, 2024
@Aprabhat19 Aprabhat19 requested review from a team as code owners January 2, 2024 13:07
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 2, 2024
@Aprabhat19 Aprabhat19 changed the title fix(core) :fix recurring mandates flow for cyber source fix(core): fix recurring mandates flow for cyber source Jan 2, 2024
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jan 2, 2024
@SamraatBansal SamraatBansal linked an issue Jan 3, 2024 that may be closed by this pull request
[BUG]: Recurring Payments via Wallets for Cybersource #3232
Closed
2 tasks
@preetamrevankar preetamrevankar added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit 6a1743e Jan 3, 2024
@preetamrevankar preetamrevankar deleted the fix-mandates branch January 3, 2024 13:42
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 7, 2024
pixincreate added a commit that referenced this pull request Jan 8, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into env_split
f65767f 
* 'main' of github.com:juspay/hyperswitch:
  fix(connector): [Stripe] Deserialization Error while parsing Dispute Webhook Body (#3256)
  refactor(euclid_wasm): Update wasm config (#3222)
  fix(analytics): added response to the connector outgoing event (#3129)
  fix(analytics): fixed response code to 501 (#3119)
  fix(connector): [NMI] Populating `ErrorResponse` with required fields and Mapping `connector_response_reference_id` (#3214)
  feat(merchant_account): Add list multiple merchants in `MerchantAccountInterface` (#3220)
  feat: include version number in response headers and on application startup (#3045)
  chore: address Rust 1.75 clippy lints (#3231)
  feat: add deep health check (#3210)
  feat(analytics): adding outgoing webhooks kafka event (#3140)
  refactor: address panics due to indexing and slicing (#3233)
  fix(users): Fix wrong redirection url in magic link (#3217)
  fix(user): add integration_completed enum in metadata type (#3245)
  chore(version): v1.106.1
  fix(connector): [iatapay] change refund amount (#3244)
  chore(version): v1.106.0
  test(postman): update postman collection files
  fix(core): fix recurring mandates flow for cyber source (#3224)
  chore: fix channel handling for consumer workflow loop (#3223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamraatBansal SamraatBansal SamraatBansal approved these changes

+1 more reviewer

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Aprabhat19 Aprabhat19

Labels
A-core Area: Core flows C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Recurring Payments via Wallets for Cybersource
5 participants
@Aprabhat19 @ArjunKarthik @SamraatBansal @SanchithHegde @preetamrevankar