Skip to content

fix: merchant_connector_id null in KV flow #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 21, 2023
Merged

fix: merchant_connector_id null in KV flow #2810

merged 4 commits into from
Nov 21, 2023

Conversation

dracarys18
Copy link
Contributor

Type of Change

  • Bugfix

Description

Added or function to use the source merhchant_connector_id if the updatable one is null

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

This fixes merchant_connector_id being null PaymentsResponse

How did you test it?

  • Create a Payment with KV merchant.
  • Confirm the Payment.
  • Check if merchant_connector_id is present in response or not

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@dracarys18 dracarys18 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 8, 2023
@dracarys18 dracarys18 added this to the November 2023 Release milestone Nov 8, 2023
@dracarys18 dracarys18 self-assigned this Nov 8, 2023
@dracarys18 dracarys18 requested a review from a team as a code owner November 8, 2023 09:52
@preetamrevankar preetamrevankar added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit e566a4e Nov 21, 2023
@preetamrevankar preetamrevankar deleted the merchant_connector_id_null branch November 21, 2023 10:30
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

+1 more reviewer

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dracarys18 dracarys18

Labels
A-core Area: Core flows
Projects
None yet
Milestone
November 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@dracarys18 @jarnura @Narayanbhat166 @SanchithHegde @preetamrevankar