Skip to content

Conversation

sahkal
Copy link
Contributor

@sahkal sahkal commented Oct 25, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add merchant custom name support for payment link

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables
    "payment_link_object": { "link_expiry" : "2025-10-09T16:23:10Z", "merchant_custom_domain_name": null, "custom_merchant_name": "sahkal" }

Motivation and Context

How did you test it?

Tested locally

Screenshot 2023-10-25 at 4 51 19 PM Screenshot 2023-10-25 at 4 51 28 PM

Testing Curl

curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_bKPPICtnI7RGJVIg97fO3Vzejk87kpO2Cggy9MULP3FcXxeQkFBHdHS6buRmk0ty' \ --data '{ "amount": 3423, "currency": "USD", "confirm": false, "customer_id": "sahkal", "return_url": "https://google.com", "description": "For selling Tea", "order_details": [ { "product_name": "Tea", "quantity": 1, "amount": 10, "product_img_link": null }, { "product_name": "Tea", "quantity": 1, "amount": 10, "product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg" }, { "product_name": "Tea", "quantity": 1, "amount": 10, "product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg" }, { "product_name": "Tea", "quantity": 1, "amount": 10, "product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg" }, { "product_name": "Tea", "quantity": 1, "amount": 10, "product_img_link": "https://thumbs.dreamstime.com/b/indian-tea-spices-masala-chai-33827904.jpg" } ], "payment_link_object": { "link_expiry": "2025-10-09T16:23:10Z", "merchant_custom_domain_name": null, "custom_merchant_name": "sahkal" } }'

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sahkal sahkal added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 labels Oct 25, 2023
@sahkal sahkal added this to the October 2023 Milestone milestone Oct 25, 2023
@sahkal sahkal requested a review from a team as a code owner October 25, 2023 11:22
@sahkal sahkal self-assigned this Oct 25, 2023
@sahkal sahkal requested a review from a team as a code owner October 25, 2023 11:22
@Narayanbhat166 Narayanbhat166 changed the title feat(router): added merchant custom name support for payment link feat(router): added merchant custom domain name support for payment link Oct 26, 2023
@Narayanbhat166 Narayanbhat166 changed the title feat(router): added merchant custom domain name support for payment link feat(router): added merchant custom name support for payment link Oct 26, 2023
jarnura
jarnura previously approved these changes Oct 27, 2023
Copy link
Member

@jarnura jarnura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sahkal sahkal removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 labels Nov 7, 2023
@likhinbopanna likhinbopanna added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 8b15189 Nov 9, 2023
@likhinbopanna likhinbopanna deleted the add-merchant-custom-name-payment-link branch November 9, 2023 11:22
@sahkal sahkal restored the add-merchant-custom-name-payment-link branch November 9, 2023 11:46
@sahkal sahkal deleted the add-merchant-custom-name-payment-link branch November 9, 2023 11:46
apoorvdixit88 pushed a commit that referenced this pull request Nov 9, 2023
)

Co-authored-by: Sahkal Poddar <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants