Skip to content

feat(connector): [ACI] Use connector_request_reference_id as reference to the connector #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2023
Merged

feat(connector): [ACI] Use connector_request_reference_id as reference to the connector #2549

merged 2 commits into from
Oct 12, 2023

Conversation

Azanul
Copy link
Contributor

@Azanul Azanul commented Oct 11, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Replaced payment_id with connector_request_reference_id

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Fixes #2203

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Azanul Azanul requested review from a team as code owners October 11, 2023 14:39
SanchithHegde
SanchithHegde reviewed Oct 11, 2023
View reviewed changes
@SanchithHegde SanchithHegde added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 11, 2023
@Azanul Azanul requested a review from SanchithHegde October 12, 2023 00:24
srujanchikke
srujanchikke approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@srujanchikke srujanchikke added S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author labels Oct 12, 2023
SanchithHegde
SanchithHegde approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @Azanul!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 12, 2023
@SanchithHegde SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners labels Oct 12, 2023
Merged via the queue into juspay:main with commit c2ad200 Oct 12, 2023
@swangi-kumari
Copy link
Contributor

Hey @Azanul ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

Assignees

@Azanul Azanul

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [ACI] Use connector_request_reference_id as reference to the connector
4 participants
@Azanul @swangi-kumari @SanchithHegde @srujanchikke