Skip to content

feat(core): add surcharge_details field to ResponsePaymentMethodTypes struct #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 5, 2023
Merged

feat(core): add surcharge_details field to ResponsePaymentMethodTypes struct #2435

merged 9 commits into from
Oct 5, 2023

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Oct 3, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added an optional surcharge_details field to ResponsePaymentMethodTypes. This field will be used to send surcharge_amount and tax_on_surcharge for that payment method type is exists during payment_method_list api call.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Manual
Screenshot 2023-10-03 at 9 47 06 PM

Curl for payment_method list

curl --location 'http://localhost:8080/account/payment_methods' \
--header 'Accept: application/json' \
--header 'api-key: dev_HOo7FzzED0kb97mNHFEbVR1TZTRX3ssBqHkpBjQ0LFQ4YquANrtrUPmVUw2MCIkY'

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 hrithikesh026 added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-api-contract-changes Metadata: This PR involves API contract changes labels Oct 3, 2023
@hrithikesh026 hrithikesh026 added this to the September 2023 Milestone milestone Oct 3, 2023
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner October 3, 2023 16:18
@hrithikesh026 hrithikesh026 self-assigned this Oct 3, 2023
@hrithikesh026 hrithikesh026 requested review from a team as code owners October 3, 2023 16:18
Narayanbhat166
Narayanbhat166 reviewed Oct 5, 2023
View reviewed changes
Narayanbhat166
Narayanbhat166 reviewed Oct 5, 2023
View reviewed changes
@jarnura jarnura added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 3f0d927 Oct 5, 2023
@jarnura jarnura deleted the add-surcharge-fields-to-payment-method-list-response branch October 5, 2023 18:36
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

+1 more reviewer

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@hrithikesh026 hrithikesh026

Labels
C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes
Projects
None yet
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hrithikesh026 @jarnura @Narayanbhat166 @SanchithHegde