Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isToggleable command state #129

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Add isToggleable command state #129

merged 1 commit into from
Nov 4, 2020

Conversation

marthacryan
Copy link
Member

This allows interfaces (including accessible ones) to indicate to the user that the command may toggle state.

@marthacryan
Copy link
Member Author

@ajbozarth

blink1073
blink1073 approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 7fa5145 into jupyterlab:master Nov 4, 2020
@isabela-pf isabela-pf mentioned this pull request Nov 5, 2020
Closed
@tgeorgeux tgeorgeux mentioned this pull request Nov 18, 2020
Closed
@marthacryan marthacryan mentioned this pull request Nov 18, 2020
Closed
@isabela-pf
Copy link

For keeping track, I think this issue is based on phosphorjs/phosphor #404.

@marthacryan marthacryan mentioned this pull request Jan 13, 2021
Merged
@isabela-pf isabela-pf mentioned this pull request Apr 7, 2021
Closed
@marthacryan marthacryan deleted the toggleable branch April 23, 2021 15:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marthacryan @isabela-pf @blink1073