Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add translation managers for server side translation #136

Merged

Conversation

goanpeca
Copy link
Member

No description provided.

@jasongrout
Copy link
Contributor

We are planning to release JupyterLab next week, which requires a release of jupyterlab_server 2.0. This is the last issue on the 2.0 milestone. What is the status? Can it be bumped, or is it ready to go in, or is it a blocker for 2.0?

@goanpeca
Copy link
Member Author

Hi @jasongrout will work on this tonight. Need to add some tests.

@blink1073
Copy link
Contributor

I just released 2.0 final. Since this is additive, it can go in a 2.1 release.

@goanpeca
Copy link
Member Author

I just released 2.0 final. Since this is additive, it can go in a 2.1 release.

Sounds good @blink1073

@goanpeca goanpeca force-pushed the add-translation-for-server-side branch from e8f72b3 to 88c92a6 Compare December 27, 2020 21:38
@goanpeca goanpeca force-pushed the add-translation-for-server-side branch from 88c92a6 to 69c1e52 Compare December 27, 2020 21:39
@codecov-io
Copy link

codecov-io commented Dec 27, 2020

Codecov Report

Merging #136 (69c1e52) into master (441624c) will increase coverage by 0.48%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   74.44%   74.92%   +0.48%     
==========================================
  Files          21       21              
  Lines        1608     1675      +67     
==========================================
+ Hits         1197     1255      +58     
- Misses        411      420       +9     
Impacted Files Coverage Δ
jupyterlab_server/translation_utils.py 87.20% <82.14%> (-1.34%) ⬇️
jupyterlab_server/tests/test_translation_api.py 99.27% <100.00%> (+0.06%) ⬆️
jupyterlab_server/translations_handler.py 91.66% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 441624c...69c1e52. Read the comment docs.

@goanpeca goanpeca changed the title WIP: Add translation managers for server side translation PR: Add translation managers for server side translation Dec 27, 2020
@goanpeca goanpeca marked this pull request as ready for review December 27, 2020 22:01
@goanpeca goanpeca self-assigned this Dec 27, 2020
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@blink1073 blink1073 merged commit eae924e into jupyterlab:master Jan 7, 2021
@blink1073
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants