-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add translation managers for server side translation #136
PR: Add translation managers for server side translation #136
Conversation
a43beb9
to
e8f72b3
Compare
We are planning to release JupyterLab next week, which requires a release of jupyterlab_server 2.0. This is the last issue on the 2.0 milestone. What is the status? Can it be bumped, or is it ready to go in, or is it a blocker for 2.0? |
Hi @jasongrout will work on this tonight. Need to add some tests. |
I just released 2.0 final. Since this is additive, it can go in a 2.1 release. |
Sounds good @blink1073 |
e8f72b3
to
88c92a6
Compare
88c92a6
to
69c1e52
Compare
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 74.44% 74.92% +0.48%
==========================================
Files 21 21
Lines 1608 1675 +67
==========================================
+ Hits 1197 1255 +58
- Misses 411 420 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
No description provided.