Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames python package and lab extension #88

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

hbcarlos
Copy link
Member

@hbcarlos hbcarlos commented Feb 13, 2023

The rename is to avoid trouble to publish on PyPI as jupyterlab-rtc is already taken.

@hbcarlos hbcarlos self-assigned this Feb 13, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (6222fd6) compared to base (6a41cbe).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #88   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          3       3           
  Lines        290     290           
=====================================
  Misses       290     290           
Impacted Files Coverage Δ
jupyterlab_collaboration/__init__.py 0.00% <0.00%> (ø)
jupyterlab_collaboration/app.py 0.00% <0.00%> (ø)
jupyterlab_collaboration/handlers.py 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fcollonval fcollonval merged commit ae5bf86 into jupyterlab:main Feb 13, 2023
@hbcarlos hbcarlos deleted the rename branch February 13, 2023 12:59
@davidbrochart
Copy link
Collaborator

I was wondering if the Python package name should be jupyter-collaboration instead of jupyterlab-collaboration, since it is independent of JupyterLab.

@fcollonval fcollonval mentioned this pull request Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants