Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames python package and lab extension #88

Merged
merged 2 commits into from
Feb 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ docs
tests
.eslintrc.js
jupyter-config
jupyterlab_rtc
jupyterlab_collaboration

packages/collaboration/babel.config.js
packages/docprovider/babel.config.js
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
- name: Run the tests with Coverage
if: ${{ !startsWith(matrix.python-version, 'pypy') && !startsWith(runner.os, 'Windows') }}
run: |
python -m pytest -vv --cov jupyterlab_rtc --cov-branch --cov-report term-missing:skip-covered
python -m pytest -vv --cov jupyterlab_collaboration --cov-branch --cov-report term-missing:skip-covered
- name: Run the tests on pypy and Windows
if: ${{ startsWith(matrix.python-version, 'pypy') || startsWith(runner.os, 'Windows') }}
run: |
Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
- uses: jupyterlab/maintainer-tools/.github/actions/test-sdist@v1
with:
extra_test: 'jupyter server extension list 2>&1 | grep -ie "jupyterlab_rtc.*OK"'
extra_test: 'jupyter server extension list 2>&1 | grep -ie "jupyterlab_collaboration.*OK"'

check_links:
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ node_modules/
*.tsbuildinfo
package-lock.json
docs/source/ts
jupyterlab_rtc/labextension
jupyterlab_collaboration/labextension

# Version file is handled by hatchling
jupyterlab_rtc/_version.py
jupyterlab_collaboration/_version.py

# Integration tests
ui-tests/test-results/
Expand Down
2 changes: 1 addition & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@
docs
tests
jupyter-config
jupyterlab_rtc
jupyterlab_collaboration
.mypy_cache
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# JupyterLab Real-Time Collaboration

[![Build Status](https://github.com/jupyterlab/jupyterlab_rtc/actions/workflows/test.yml/badge.svg?query=branch%3Amain++)](https://github.com/jupyterlab/jupyterlab_rtc/actions?query=branch%3Amain++)
[![Build Status](https://github.com/jupyterlab/jupyterlab_collaboration/actions/workflows/test.yml/badge.svg?query=branch%3Amain++)](https://github.com/jupyterlab/jupyterlab_collaboration/actions?query=branch%3Amain++)

JupyterLab Real-Time Collaboration is a Jupyter Server Extension and JupyterLab extensions providing support for Y documents
and adding collaboration UI elements in JupyterLab.
Expand All @@ -13,13 +13,13 @@ To install the latest release locally, make sure you have
[pip installed](https://pip.readthedocs.io/en/stable/installing/) and run:

```bash
pip install jupyterlab-rtc
pip install jupyterlab_collaboration
```

Or using ``conda``/``mamba``:

```bash
conda install jupyterlab-rtc
conda install jupyterlab_collaboration
```

### Testing
Expand Down
8 changes: 4 additions & 4 deletions docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# -- Project information -----------------------------------------------------
# https://www.sphinx-doc.org/en/master/usage/configuration.html#project-information

project = "jupyterlab_rtc"
project = "jupyterlab_collaboration"
copyright = f"2022-{time.localtime().tm_year}, Jupyter Development Team" # noqa
author = "Jupyter Development Team"
release = "0.3.0"
Expand Down Expand Up @@ -58,7 +58,7 @@
"type": "local",
}
],
"github_url": "https://github.com/jupyterlab/jupyterlab_rtc",
"github_url": "https://github.com/jupyterlab/jupyterlab_collaboration",
"use_edit_page_button": True,
"show_toc_level": 1,
"navbar_align": "left",
Expand All @@ -69,7 +69,7 @@
# Output for github to be used in links
html_context = {
"github_user": "jupyterlab", # Username
"github_repo": "jupyterlab_rtc", # Repo name
"github_repo": "jupyterlab_collaboration", # Repo name
"github_version": "main", # Version
"conf_py_path": "/docs/source/", # Path in the checkout to the docs root
}
Expand All @@ -87,7 +87,7 @@ def setup(app):
js_docs = HERE / "ts" / "api"
collaboration = js_docs / "collaboration"
docprovider = js_docs / "docprovider"
extension = js_docs / "rtc-extension"
extension = js_docs / "collaboration-extension"

if collaboration.exists() and docprovider.exists() and extension.exists():
# avoid rebuilding docs because it takes forever
Expand Down
2 changes: 1 addition & 1 deletion docs/source/developer/architecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ COMING...
Prior to the current implementation based on [Yjs](https://docs.yjs.dev/), other attempts using
different technologies where tried:

- Attempt based on [Automerge](https://automerge.org/). The code has been archived in that [branch](https://github.com/jupyterlab/jupyterlab_rtc/tree/automerge). You can
- Attempt based on [Automerge](https://automerge.org/). The code has been archived in that [branch](https://github.com/jupyterlab/jupyterlab_collaboration/tree/automerge). You can
access the [documentation there](https://jupyterlab-realtime-collaboration.readthedocs.io/en/automerge/).
16 changes: 8 additions & 8 deletions docs/source/developer/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ Once you have installed the dependencies mentioned above, use the following
steps::

pip install --upgrade pip
git clone https://github.com/jupyterlab/jupyterlab_rtc
cd jupyterlab_rtc
git clone https://github.com/jupyterlab/jupyterlab_collaboration
cd jupyterlab_collaboration
pip install -e .

If you are using a system-wide Python installation and you only want to install the server for you,
Expand All @@ -48,7 +48,7 @@ from any directory in your system with::
Code Styling
^^^^^^^^^^^^

``jupyterlab_rtc`` has adopted automatic code formatting so you shouldn't
``jupyterlab_collaboration`` has adopted automatic code formatting so you shouldn't
need to worry too much about your code style.
As long as your code is valid,
the pre-commit hook should take care of how it should look.
Expand Down Expand Up @@ -81,9 +81,9 @@ Troubleshooting the Installation
If you do not see that your Jupyter Server is not running on dev mode, it's possible that you are
running other instances of Jupyter Server. You can try the following steps:

1. Uninstall all instances of the jupyterlab_rtc package. These include any installations you made using
1. Uninstall all instances of the jupyterlab_collaboration package. These include any installations you made using
pip or conda
2. Run ``python3 -m pip install -e .`` in the jupyterlab_rtc repository to install jupyterlab_rtc from there
2. Run ``python3 -m pip install -e .`` in the jupyterlab_collaboration repository to install jupyterlab_collaboration from there
3. Launch with ``python3 -m jupyter_server --port 8989``, and check that the browser is pointing to ``localhost:8989``
(rather than the default 8888). You don't necessarily have to launch with port 8989, as long as you use
a port that is neither the default nor in use, then it should be fine.
Expand All @@ -99,7 +99,7 @@ Install dependencies::

To run the Python tests, use::

pytest jupyterlab_rtc
pytest jupyterlab_collaboration


Building the Docs
Expand All @@ -108,11 +108,11 @@ Building the Docs
To build the documentation you'll need `Sphinx <http://www.sphinx-doc.org/en/master/>`_,
`pandoc <https://pandoc.org/>`_ and a few other packages.

To install (and activate) a `conda environment`_ named ``jupyterlab_rtc_docs``
To install (and activate) a `conda environment`_ named ``jupyterlab_collaboration_docs``
containing all the necessary packages (except pandoc), use::

conda env create -f docs/environment.yml
conda activate jupyterlab_rtc_docs
conda activate jupyterlab_collaboration_docs

.. _conda environment:
https://conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html#creating-an-environment-from-an-environment-yml-file
Expand Down
4 changes: 2 additions & 2 deletions docs/source/developer/python_api.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
Python API
==========

.. automodule:: jupyterlab_rtc.app
.. automodule:: jupyterlab_collaboration.app
:members:
:inherited-members:

.. automodule:: jupyterlab_rtc.handlers
.. automodule:: jupyterlab_collaboration.handlers
:members:
:inherited-members:
6 changes: 3 additions & 3 deletions docs/source/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@ contain the root `toctree` directive.
From JupyterLab v4, file documents and notebooks have collaborative
editing using the [Yjs shared editing framework](https://github.com/yjs/yjs).
Editors are not collaborative by default; to activate it, install the extension
`jupyterlab_rtc`.
`jupyterlab_collaboration`.

Installation using mamba/conda:

```sh
mamba install -c conda-forge jupyterlab_rtc
mamba install -c conda-forge jupyterlab_collaboration
```

Installation using pip:

```sh
pip install jupyterlab_rtc
pip install jupyterlab_collaboration
```

To share a document with other users, you can copy the URL and send it, or you
Expand Down
4 changes: 2 additions & 2 deletions install.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"packageManager": "python",
"packageName": "jupyterlab_rtc",
"uninstallInstructions": "Use your Python package manager (pip, conda, etc.) to uninstall the package jupyterlab_rtc"
"packageName": "jupyterlab_collaboration",
"uninstallInstructions": "Use your Python package manager (pip, conda, etc.) to uninstall the package jupyterlab_collaboration"
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"ServerApp": {
"jpserver_extensions": {
"jupyterlab_rtc": true
"jupyterlab_collaboration": true
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@


def _jupyter_labextension_paths():
return [{"src": "labextension", "dest": "@jupyterlab/rtc-extension"}]
return [{"src": "labextension", "dest": "@jupyterlab/collaboration-extension"}]


def _jupyter_server_extension_points() -> List[Dict[str, Any]]:
return [{"module": "jupyterlab_rtc", "app": YDocExtension}]
return [{"module": "jupyterlab_collaboration", "app": YDocExtension}]
2 changes: 1 addition & 1 deletion jupyterlab_rtc/app.py → jupyterlab_collaboration/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@


class YDocExtension(ExtensionApp):
name = "jupyterlab_rtc"
name = "jupyterlab_collaboration"

file_poll_interval = Int(
1,
Expand Down
File renamed without changes.
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
"jupyterlab",
"jupyterlab-extension"
],
"homepage": "https://github.com/jupyterlab/jupyterlab_rtc",
"homepage": "https://github.com/jupyterlab/jupyterlab_collaboration",
"bugs": {
"url": "https://github.com/jupyterlab/jupyterlab_rtc/issues"
"url": "https://github.com/jupyterlab/jupyterlab_collaboration/issues"
},
"repository": {
"type": "git",
"url": "https://github.com/jupyterlab/jupyterlab_rtc.git"
"url": "https://github.com/jupyterlab/jupyterlab_collaboration.git"
},
"license": "BSD-3-Clause",
"author": {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# @jupyterlab/rtc-extension
# @jupyterlab/collaboration-extension

A JupyterLab package which provides a set of plugins for Real Time Collaboration.
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"name": "@jupyterlab/rtc-extension",
"name": "@jupyterlab/collaboration-extension",
"version": "4.0.0-alpha.19",
"description": "JupyterLab - RTC Extension",
"keywords": [
"jupyter",
"jupyterlab",
"jupyterlab-extension"
],
"homepage": "https://github.com/jupyterlab/jupyterlab_rtc",
"homepage": "https://github.com/jupyterlab/jupyterlab_collaboration",
"bugs": {
"url": "https://github.com/jupyterlab/jupyterlab_rtc/issues"
"url": "https://github.com/jupyterlab/jupyterlab_collaboration/issues"
},
"repository": {
"type": "git",
"url": "https://github.com/jupyterlab/jupyterlab_rtc.git"
"url": "https://github.com/jupyterlab/jupyterlab_collaboration.git"
},
"license": "BSD-3-Clause",
"author": "Project Jupyter",
Expand Down Expand Up @@ -44,7 +44,7 @@
"build:labextension:dev": "jupyter labextension build --development True .",
"clean": "jlpm run clean:lib",
"clean:lib": "rimraf lib tsconfig.tsbuildinfo node_modules",
"clean:labextension": "rimraf ../../jupyterlab_rtc/labextension",
"clean:labextension": "rimraf ../../jupyterlab_collaboration/labextension",
"clean:all": "jlpm run clean:lib && jlpm run clean:labextension",
"install:extension": "jlpm run build",
"watch": "run-p watch:src watch:labextension",
Expand Down Expand Up @@ -81,13 +81,13 @@
"typedoc": {
"entryPoint": "./src/index.ts",
"readmeFile": "./README.md",
"displayName": "@jupyterlab/rtc-extension",
"displayName": "@jupyterlab/collaboration-extension",
"tsconfig": "./tsconfig.json"
},
"jupyterlab": {
"extension": true,
"schemaDir": "./schema",
"outputDir": "../../jupyterlab_rtc/labextension",
"outputDir": "../../jupyterlab_collaboration/labextension",
"disabledExtensions": [
"@jupyterlab/filebrowser-extension:defaultFileBrowser"
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import { WebsocketProvider } from 'y-websocket';
* Jupyter plugin providing the IUserMenu.
*/
export const userMenuPlugin: JupyterFrontEndPlugin<IUserMenu> = {
id: '@jupyterlab/rtc-extension:userMenu',
id: '@jupyterlab/collaboration-extension:userMenu',
autoStart: true,
requires: [],
provides: IUserMenu,
Expand All @@ -51,7 +51,7 @@ export const userMenuPlugin: JupyterFrontEndPlugin<IUserMenu> = {
* Jupyter plugin adding the IUserMenu to the menu bar if collaborative flag enabled.
*/
export const menuBarPlugin: JupyterFrontEndPlugin<void> = {
id: '@jupyterlab/rtc-extension:userMenuBar',
id: '@jupyterlab/collaboration-extension:userMenuBar',
autoStart: true,
requires: [IUserMenu],
activate: async (app: JupyterFrontEnd, menu: IUserMenu): Promise<void> => {
Expand Down Expand Up @@ -80,7 +80,7 @@ export const menuBarPlugin: JupyterFrontEndPlugin<void> = {
* Jupyter plugin creating a global awareness for RTC.
*/
export const rtcGlobalAwarenessPlugin: JupyterFrontEndPlugin<IAwareness> = {
id: '@jupyterlab/rtc-extension:rtcGlobalAwareness',
id: '@jupyterlab/collaboration-extension:rtcGlobalAwareness',
autoStart: true,
requires: [IStateDB],
provides: IGlobalAwareness,
Expand Down Expand Up @@ -129,7 +129,7 @@ export const rtcGlobalAwarenessPlugin: JupyterFrontEndPlugin<IAwareness> = {
* Jupyter plugin adding the RTC information to the application left panel if collaborative flag enabled.
*/
export const rtcPanelPlugin: JupyterFrontEndPlugin<void> = {
id: '@jupyterlab/rtc-extension:rtcPanel',
id: '@jupyterlab/collaboration-extension:rtcPanel',
autoStart: true,
requires: [IGlobalAwareness, ITranslator],
activate: (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ namespace CommandIDs {
* The default file browser factory provider.
*/
export const defaultFileBrowser: JupyterFrontEndPlugin<IDefaultFileBrowser> = {
id: '@jupyterlab/rtc-extension:defaultFileBrowser',
id: '@jupyterlab/collaboration-extension:defaultFileBrowser',
provides: IDefaultFileBrowser,
requires: [IFileBrowserFactory],
optional: [IRouter, JupyterFrontEnd.ITreeResolver, ILabShell],
Expand All @@ -36,7 +36,9 @@ export const defaultFileBrowser: JupyterFrontEndPlugin<IDefaultFileBrowser> = {
tree: JupyterFrontEnd.ITreeResolver | null,
labShell: ILabShell | null
): Promise<IDefaultFileBrowser> => {
console.debug('@jupyterlab/rtc-extension:defaultFileBrowser: activated');
console.debug(
'@jupyterlab/collaboration-extension:defaultFileBrowser: activated'
);
const { commands } = app;

const drive = new YDrive(app.serviceManager.user);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Distributed under the terms of the Modified BSD License.
/**
* @packageDocumentation
* @module rtc-extension
* @module collaboration-extension
*/

import { JupyterFrontEndPlugin } from '@jupyterlab/application';
Expand Down
6 changes: 3 additions & 3 deletions packages/collaboration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
"name": "@jupyterlab/collaboration",
"version": "4.0.0-alpha.19",
"description": "JupyterLab - Real Time Collaboration Widgets",
"homepage": "https://github.com/jupyterlab/jupyterlab_rtc",
"homepage": "https://github.com/jupyterlab/jupyterlab_collaboration",
"bugs": {
"url": "https://github.com/jupyterlab/jupyterlab_rtc/issues"
"url": "https://github.com/jupyterlab/jupyterlab_collaboration/issues"
},
"repository": {
"type": "git",
"url": "https://github.com/jupyterlab/jupyterlab_rtc.git"
"url": "https://github.com/jupyterlab/jupyterlab_collaboration.git"
},
"license": "BSD-3-Clause",
"author": "Project Jupyter",
Expand Down
Loading