Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jupyter file ID service if installed #41

Merged
merged 9 commits into from
Oct 28, 2022

Conversation

davidbrochart
Copy link
Collaborator

No description provided.

@davidbrochart davidbrochart marked this pull request as draft October 14, 2022 15:35
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (fe98d7f) compared to base (10c6ae2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #41   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          2       2           
  Lines        195     218   +23     
=====================================
- Misses       195     218   +23     
Impacted Files Coverage Δ
jupyter_server_ydoc/__init__.py 0.00% <0.00%> (ø)
jupyter_server_ydoc/ydoc.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidbrochart davidbrochart added the enhancement New feature or request label Oct 17, 2022
@davidbrochart davidbrochart marked this pull request as ready for review October 18, 2022 15:38
@davidbrochart davidbrochart changed the title Use file ID Add optional file_id to file_path callback Oct 18, 2022
@davidbrochart
Copy link
Collaborator Author

8db6b68 will need jupyter-server/jupyter_ydoc#81.

@davidbrochart davidbrochart changed the title Add optional file_id to file_path callback Use Jupyter file ID service if installed Oct 25, 2022
@davidbrochart davidbrochart merged commit 5476673 into jupyterlab:main Oct 28, 2022
@davidbrochart davidbrochart deleted the file_id branch October 28, 2022 08:41
@SylvainCorlay
Copy link
Member

Awesome!

hbcarlos pushed a commit to hbcarlos/jupyter-collaboration that referenced this pull request Jan 29, 2023
* Use file ID

* Get id2path from server settings

* Remove jupyter_server_fileid dependency

* get_file_info() doesn't return file_id

* Set Y document path

* Add GET room ID handler, directly access file ID manager

* Call sync_all() if get_path(id) returns None

* Change GET to PUT with body, return room ID

* sync_all() is not needed anymore in jupyter_server_fileid v0.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants