Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't unobserve and observe again #39

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Don't unobserve and observe again #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71e04a4
Don't unobserve and observe again
davidbrochart Oct 4, 2022
1191162
Fix Test Prereleases
davidbrochart Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ jobs:
pip check
- name: Run the tests
run: |
pytest -vv || pytest -vv --lf
pytest -vv -W default || pytest -vv --lf

make_sdist:
name: Make SDist
Expand Down
4 changes: 0 additions & 4 deletions jupyter_server_ydoc/ydoc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,6 @@ def on_document_change(self, event):
return
except Exception:
pass
# unobserve and observe again because the structure of the document may have changed
# e.g. a new cell added to a notebook
self.room.document.unobserve()
self.room.document.observe(self.on_document_change)
if self.saving_document is not None and not self.saving_document.done():
# the document is being saved, cancel that
self.saving_document.cancel()
Expand Down