Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies to fix CI #335

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

krassowski
Copy link
Member

Fixes failing CI spotted in #334 (review)

Copy link
Contributor

Binder 👈 Launch a Binder on branch krassowski/jupyter_collaboration/bump-collaboration-dependencies

@krassowski krassowski added the bug Something isn't working label Aug 12, 2024
@krassowski
Copy link
Member Author

Huh, it's still picking the old versions:

Collecting jupyter-collaboration-ui@ file:///home/runner/work/jupyter-collaboration/jupyter-collaboration/projects/jupyter-collaboration-ui (from jupyter-collaboration-monorepo==3.0.0b1)
  Using cached jupyter_collaboration_ui-1.0.0b0-py3-none-any.whl
Collecting jupyter-collaboration@ file:///home/runner/work/jupyter-collaboration/jupyter-collaboration/projects/jupyter-collaboration (from jupyter-collaboration-monorepo==3.0.0b1)
  Using cached jupyter_collaboration-3.0.0b0-py3-none-any.whl
Collecting jupyter-docprovider@ file:///home/runner/work/jupyter-collaboration/jupyter-collaboration/projects/jupyter-docprovider (from jupyter-collaboration-monorepo==3.0.0b1)
  Using cached jupyter_docprovider-1.0.0b0-py3-none-any.whl
Collecting jupyter-server-ydoc@ file:///home/runner/work/jupyter-collaboration/jupyter-collaboration/projects/jupyter-server-ydoc (from jupyter-collaboration-monorepo==3.0.0b1)
  Using cached jupyter_server_ydoc-1.0.0b0-py3-none-any.whl

@krassowski
Copy link
Member Author

It looks like the upstream maintainer-tools pip cache does not consider dependencies further down the line:

        key: ${{ env.CACHE_PREFIX }}-pip-${{ env.PYTHON_VERSION }}-${{ hashFiles('setup.cfg', 'setup.py', '**/requirements.txt') }}

https://github.com/jupyterlab/maintainer-tools/blob/3becc873eb192cc039d37547d34495dfdf80e8af/.github/actions/base-setup/action.yml#L56-L62

@krassowski
Copy link
Member Author

I opened jupyterlab/maintainer-tools#244

@krassowski krassowski marked this pull request as ready for review August 12, 2024 12:31
@krassowski
Copy link
Member Author

All green!

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 7ea2cd5 into jupyterlab:main Aug 13, 2024
20 checks passed
@krassowski krassowski deleted the bump-collaboration-dependencies branch August 17, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants