Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fixtures to jupyter_server_ydoc.pytest_plugin #327

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Move fixtures to jupyter_server_ydoc.pytest_plugin #327

merged 3 commits into from
Jul 19, 2024

Conversation

krassowski
Copy link
Member

Fixes #326

@krassowski krassowski added the enhancement New feature or request label Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch krassowski/jupyter_collaboration/pytest-plugin

@krassowski krassowski force-pushed the pytest-plugin branch 2 times, most recently from af9efa0 to f3dfbe4 Compare July 18, 2024 09:53
@krassowski krassowski marked this pull request as ready for review July 18, 2024 11:33
@krassowski
Copy link
Member Author

All green! I would appreciate a review because I would like to open another PR on top of these reshuffle and release this in another beta :)

@krassowski krassowski mentioned this pull request Jul 18, 2024
Merged
brichet
brichet approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @krassowski

@krassowski krassowski merged commit 1ae2625 into jupyterlab:main Jul 19, 2024
20 checks passed
@fcollonval fcollonval mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brichet brichet brichet approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract fixtures to a pytest plugin
2 participants
@krassowski @brichet