Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pycrdt-websocket>=0.14.0,<0.15.0 #323

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

davidbrochart
Copy link
Collaborator

No description provided.

Copy link
Contributor

Binder 👈 Launch a Binder on branch davidbrochart/jupyter_collaboration/pycrdt-websocket-v0.14

@krassowski
Copy link
Member

Maybe rebasing here could help to fix the failing tests?

@davidbrochart
Copy link
Collaborator Author

Maybe rebasing here could help to fix the failing tests?

It's a PR against the 2.x branch, so no need to rebase.

@davidbrochart davidbrochart reopened this Jul 22, 2024
@Zsailer
Copy link
Member

Zsailer commented Jul 24, 2024

Thanks, @davidbrochart

@jzhang20133
Copy link
Collaborator

Thanks, @davidbrochart! In our recent test, after upgrading to this version, we stop seeing rapid memory growth while using RTC.

@davidbrochart
Copy link
Collaborator Author

davidbrochart commented Jul 24, 2024

Interesting, it's hard to say what exactly is responsible for this, it may be the recent update to PyO3 v0.22.1 or the various improvements in Yrs.

@davidbrochart davidbrochart merged commit 1d602b1 into jupyterlab:2.x Jul 24, 2024
33 of 38 checks passed
@davidbrochart davidbrochart deleted the pycrdt-websocket-v0.14 branch July 24, 2024 13:03
@davidbrochart
Copy link
Collaborator Author

Released in v2.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants