Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fileId instead of path in the store #174

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Use fileId instead of path in the store #174

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7912409
Use fileId instead as path when storing the updates
hbcarlos Jun 29, 2023
2554ed7
Updates file name in the store
hbcarlos Jul 5, 2023
b2a15de
Run pre-commit
hbcarlos Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions jupyter_collaboration/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import asyncio
import json
import uuid
from pathlib import Path
from typing import Any

from jupyter_server.auth import authorized
Expand Down Expand Up @@ -84,9 +83,7 @@ async def prepare(self):
)

file = self._file_loaders[file_id]
path = self._file_id_manager.get_path(file_id)
path = Path(path)
updates_file_path = str(path.parent / f".{file_type}:{path.name}.y")
updates_file_path = f".{file_type}:{file_id}.y"
ystore = self._ystore_class(path=updates_file_path, log=self.log)
self.room = DocumentRoom(
self._room_id,
Expand Down