Skip to content

Commit

Permalink
Fix mypy (#358)
Browse files Browse the repository at this point in the history
* Remove type ignore that make mypy fails

* Fix the increment version

* Revert "Fix the increment version"

This reverts commit c24d5ca.

* Revert "Remove type ignore that make mypy fails"

This reverts commit 2af5bc8.

* Ignore bump script with mypy

* Remove unnecessary type ignore

* Exclude file in pre-commit config

---------

Co-authored-by: David Brochart <[email protected]>
  • Loading branch information
brichet and davidbrochart authored Sep 20, 2024
1 parent 56fa7b7 commit bbb2f83
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ repos:
rev: v0.991
hooks:
- id: mypy
exclude: "(^binder/jupyter_config\\.py$)|(/setup\\.py$)"
exclude: "(^binder/jupyter_config\\.py$)|(^scripts/bump_version\\.py$)|(/setup\\.py$)"
args: ["--config-file", "pyproject.toml"]
additional_dependencies: [tornado, pytest]
stages: [manual]
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ filterwarnings = [
[tool.mypy]
exclude=[
"^binder/jupyter_config\\.py$",
"^scripts/bump_version\\.py$",
"/setup\\.py$",
]
check_untyped_defs = true
Expand Down
2 changes: 1 addition & 1 deletion scripts/bump_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import click
import tomlkit
from jupyter_releaser.util import get_version, run
from pkg_resources import parse_version # type: ignore
from pkg_resources import parse_version

LERNA_CMD = "jlpm run lerna version --no-push --force-publish --no-git-tag-version"

Expand Down

0 comments on commit bbb2f83

Please sign in to comment.