Backport 'Fix mypy' #358 (#361)

jupyterlab · Sep 20, 2024 · 1532651 · 1532651
1 parent 35fdf7b
commit 1532651
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -60,7 +60,7 @@ repos:
     rev: v0.991
     hooks:
       - id: mypy
-        exclude: "^binder/jupyter_config\\.py$"
+        exclude: "(^binder/jupyter_config\\.py$)|(^scripts/bump_version\\.py$)"
         args: ["--config-file", "pyproject.toml"]
         additional_dependencies: [tornado, pytest]
         stages: [manual]

diff --git a/pyproject.toml b/pyproject.toml
@@ -151,6 +151,7 @@ filterwarnings = [
 [tool.mypy]
 exclude=[
     "^binder/jupyter_config\\.py$",
+    "^scripts/bump_version\\.py$",
 ]
 check_untyped_defs = true
 disallow_any_generics = false

diff --git a/scripts/bump_version.py b/scripts/bump_version.py
@@ -6,7 +6,7 @@
 
 import click
 from jupyter_releaser.util import get_version, run
-from pkg_resources import parse_version  # type: ignore
+from pkg_resources import parse_version
 
 LERNA_CMD = "jlpm run lerna version --no-push --force-publish --no-git-tag-version"