-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Absorb the Phosphor Project #28
Comments
I would suggest using @jupyterlab-phosphor/algorithm (etc.) - While I suspect "phospor" can't be copyrighted, I would still seek written permission from @sccolbert first and if not given, then consider switching - but it is/was his baby and keeping the name will help preserve his legacy on the project. I have a few housekeeping PRs I use on my fork which may be of interest:
Plus there is a whole ecosystem of visualizations which play well with the DockPanel (Shameless plug): |
Thanks for starting this discussion.
Good feature ideas, but I think with all the things in motion right now,
what we mostly need is clear, official messaging that Jupyter can provide
(even if we haven't done it yet):
- re-released packages of the dependencies in question of current lab heads
(presumably, 1.1.*, 1.2.*, 2.*) that downstreams can use confidently with
an identical API.
- a review/ci infrastructure ready to accept contributions and react to
them in a timely manner
- a readiness (indeed, enthusiasm) to respect the needs of other
contributing downstreams
- some tooling which can help with the transition
The worst things that could happen to lab adoption until all that is in
place is users and downstreams, due to fork FUD, rather than on a rational
assessment of the work and the investment it represents...
- stopping work
- starting more, private, or otherwise incompatible-for-no-reason forks of
the libraries in question or lab
- picking something else to base their work on
- not starting new work at all, hurting users
PR (ha) aside:
There are obvious advantages to moving all the libraries in question into
the jl/jl monorepo, and this can be done in a way that preserves history
while still respecting the wishes of all involved... e.g. git filter branch.
I hope we do maintain (therefore test) a hard separation of deps, though,
as allowing react/blueprint/d3/etc to infect the otherwise unopinionated
dependency tree would reduce its adoptability.
Because of the collisions with @jupyterlab (e.g coreutils), it seems we
need a namespace, irrespective of where it lives.
Ideally, something that is short, isn't too clever or derivative, on-brand,
without being too lab-centric might have the greatest chance of getting
outside contribution.
Haven't don't the brand/seo drive-though but perhaps some things like
@-on-npm:
- jupyterkit
- jupytoolkit
- jupytypes
- jupycore
- jupycleus
- jptk
- jpui
- jpyde
- jig
I dunno.
It may also be worth opening this up to the various mailing lists, which
get some more eyes.
I'd be happy help with the rebrand, once we get to that point, having done
some work on the OG stuff back in the day. We likely will still want
dedicated docs, examples, etc. but can be a bit more liberal with cross
linking to lab for examples, which may well be the only in-the-wild use of
a particular api.
…On Sat, Nov 9, 2019, 02:18 Gordon Smith ***@***.***> wrote:
I would suggest using @jupyterlab/phosphor - While I suspect "phospor"
can't be copyrighted, I would still seek written permission from
@sccolbert <https://github.com/sccolbert> first and if not given, then
consider switching - but it is/was his baby and keeping the name will help
preserve his legacy on the project.
I have a few housekeeping PRs I use on my fork which may be of interest:
- Add typescript types to published package
- UMD / es6 Support
- Updated to latest TS Compiler
- Use NPM instead of YARN (somewhat opinionated, but Yarn was masking
some missing dependency issues between the projects)
- Removal of unofficial dom functions (setImmediate / clearImmediate)
- Some minor enhancements to the DockPanel
- etc.
Plus there is a whole ecosystem of visualizations which play well with the
DockPanel (Shameless plug):
-
https://raw.githack.com/hpcc-systems/Visualization/master/demos/gallery/gallery.html?./samples/layout
-
https://raw.githack.com/hpcc-systems/Visualization/master/demos/gallery/gallery.html
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#28>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRDLUSJRICUYKXS23FLQSZP2TANCNFSM4JLDJKNA>
.
|
I think its important to keep it as separate as possible, there are plenty of applications that rely on phosphor that don't want to pull in a bunch of jupyter-specific code. |
Please avoid antagonistic comments, @sccolbert's contributions to this project are extensive and appreciated, and any questions/comments about reasonings for archiving the phosphorjs project should be taken up individually. |
Sure, thanks for cleaning my comment up @timkpaine. We've all invested a lot in this work over the last n years, and I'm personally grateful to everyone I've had the opportunity to work with during that time around the code. Just trying to point out that a potential downstream would interpret the current guidance as a 🔴 🎩 -style-trademark-thing, rather than a BSD-conformance-thing, underlining the need to get something relatively official out soon which fully complies with the guidance. |
Here are few possible ideas on renaming/rebranding. I mostly went down a chemistry-related allusion hole, so take these as seriously/not-seriously as you like:
|
@ian-r-rose i was thinking in the same vein, phosphor is an old name for phosphorus, so I was looking at other old chemical names. Could also go for a moon https://en.m.wikipedia.org/wiki/Moons_of_Jupiter |
More thoughts on the connection with light:
More elements close to it on the periodic table:
|
Picking something in the same group as would reflect compatibility:
- nitrogen, n (taken)
- arsenic, as (taken)
- antimony, an (open)
- used in batteries, 🔥 retardant, micro electronics
- css classes would be funny, an-Widget
- not in it for the mon(e)y
- bismuth (taken)
- moscovium (open but meh)
There are archaic forms of the above as well...
|
"What's Jupiter made of?" Roughly 90% hydrogen and 10% helium. So I would say we should hydrogen as the new name, but someone beat us to that... |
@jasongrout already pointed out (we had this conversation elsewhere) that the name In Colombia, 'fósforo' is both the element "phosphor" and the colloquial name for match (as in the little wooden sticks with flammable bit at the end), b/c the flammable tip of matches typically has a lot of phosphor in it (or used to, I have no idea how they're made today). And the name for a fluid lighter is --again colloquially-- "candela", which more precisely is a synonym for fire. The "proper" Spanish words are cerilla (match) and encendedor (lighter), but in Colombia everybody uses fósforo and candela. The word candela actually exists in English, it's the the SI unit for luminous intensity (meaning it's physical radiance but integrated with the human visual model of wavelength-dependent sensitivity). |
Some more suggestions from our meeting today:
|
When we were discussing it, "lumino" kept coming back as a favorite. What do people think about calling the new project Lumino? (feel free to use thumbs up/down, or leave a comment for a nuanced response) Reasons for Lumino:
And as one person said, it's cuter than "lux" |
Also, someone suggested the proper Spanish word for "bright": luminosa |
Lumino also comes from "Luminophore", which has two types, Phosphor and
Fluorophore. Kind of a cool callback to phosphor as well :)
https://en.wikipedia.org/wiki/Luminophore
…On Wed, Nov 13, 2019 at 3:34 PM Jason Grout ***@***.***> wrote:
Also, someone suggested the proper Spanish word for "bright": luminosa
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#28>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFIVZQGVKKJSQRXPXXNAXS3QTSFJBANCNFSM4JLDJKNA>
.
|
👍 to |
(sry, just didn't look hard enough, you can check by URL, e.g. |
By @blink1073, this morning, just in case :) |
I am +1 on Lumino. Good looking out @blink1073 !
—
… You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#28>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFIVZQCVUAFB7XSU5JXJ77DQTS463ANCNFSM4JLDJKNA>
.
|
More bike-shedding: this is what the package list would look like:
|
🚵♂️ 🏠 ed some font ideas
some criteria:
On individual fonts:
|
As for the inhabitants of the bikeshed: I'd love to bring in a jo-like treatment for this... unsurprisingly lu. Lu's probably a bit more boxy than jo, maybe a little more transforming-pet-like, and helps jo get things done. I can imagine a team of lus:
|
When rebooting the docs, it would perhaps be a good time to revisit sphinx-js for the autogenerated parts, which should likely be considered for lab as well. Also, it would be very interesting to make a mini-jyve for dogfooding the docs with interactive examples... might as well go ahead and ship the typescript interepreter, which basically has all the nuts and bolts for a language server experience, especially with monaco. |
+1 on Lumino. |
I think the consensus if for |
Sounds good to me. +1. |
IIRC, we were going to release packages with exactly the same commit as the last released phosphor packages to make the transition for anyone literally a name change (with no code changes)? |
Yes, that sounds right |
I created the repo and made a release of all packages. I did the following:
|
@blink1073 Thanks for handling the logistics here! Would you now say that the process is completed, or are there any remaining tasks? |
Sounds good, I created jupyterlab/jupyterlab#7534 to track the rest of the transition. |
This issue has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/is-phosphorjs-no-longer-supported/3451/2 |
The Phosphor project has been archived by the author, and the name is no longer usable. Here we propose to bring the existing code base as a new repository under the JupyterLab GitHub org, and give it a new name. I say we give a week for folks to give suggestions on a new name.
The text was updated successfully, but these errors were encountered: