Fix environment variable leak for unused formatters #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
force-pushed
the
fix-rpy2-leak
branch
from
d131113 to
44c07c8
Compare
krassowski
force-pushed
the
fix-rpy2-leak
branch
from
44c07c8 to
c16cd92
Compare
krassowski
force-pushed
the
fix-rpy2-leak
branch
from
f511311 to
6774b85
Compare
|
All green! |
|
Code looks good, and tests passed for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #337
Previously the environment was polluted by
rpy2variables even when no R formatter (styler nor formatR) was installed. This was first happening on import offormatters.pyand then when checking if these formatters are importable because each of these steps contained anrpy2import.With this change
rpy2is only imported when needed.