-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for k8s 1.21 #3041
Conversation
@@ -135,12 +135,12 @@ jobs: | |||
test: install | |||
local-chart-extra-args: >- | |||
--set hub.image.name=jupyterhub/k8s-hub-slim | |||
- k3s-channel: v1.22 # also test prePuller.hook | |||
- k3s-channel: v1.26 # also test prePuller.hook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an upgrade test using k8s 1.22 still defined below.
Can we drop 1.22 as well? May 2023 seems close enough, and it sets expectations now. |
I'd like to do so too and get z2jh 3.0.0 with jupyterhub 4 together with releases of kubespawner/oauthenticator out. I think maybe I can help better testing the existing dev branches with jupyterhub 4 if we don't remove k8s 1.22 support just before we must. Due to that, and due to I already have a PR ready to push open to drop 1.22 support I'd like to have that be a separate PR.
|
If you're not dropping 1.22 immediately can you update https://github.com/jupyterhub/zero-to-jupyterhub-k8s/blob/main/docs/source/changelog.md#unreleased-breaking-changes ? |
Done already! I'll update it again in the next pr when we require k8s 1.23+! |
jupyterhub/zero-to-jupyterhub-k8s#3041 Merge pull request #3041 from consideRatio/pr/require-k8s-1.22
I squeezed in a few smaller docs updates into this PR that could have been separate PRs. The linkcheck failure is unrelated and reported in jupyterhub/jupyterhub#4376.