Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for k8s 1.21 #3041

Merged
merged 4 commits into from
Mar 1, 2023
Merged

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Feb 28, 2023

I squeezed in a few smaller docs updates into this PR that could have been separate PRs. The linkcheck failure is unrelated and reported in jupyterhub/jupyterhub#4376.

@@ -135,12 +135,12 @@ jobs:
test: install
local-chart-extra-args: >-
--set hub.image.name=jupyterhub/k8s-hub-slim
- k3s-channel: v1.22 # also test prePuller.hook
- k3s-channel: v1.26 # also test prePuller.hook
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an upgrade test using k8s 1.22 still defined below.

@manics
Copy link
Member

manics commented Feb 28, 2023

Can we drop 1.22 as well? May 2023 seems close enough, and it sets expectations now.

@consideRatio
Copy link
Member Author

consideRatio commented Mar 1, 2023

Can we drop 1.22 as well? May 2023 seems close enough, and it sets expectations now.

I'd like to do so too and get z2jh 3.0.0 with jupyterhub 4 together with releases of kubespawner/oauthenticator out.

I think maybe I can help better testing the existing dev branches with jupyterhub 4 if we don't remove k8s 1.22 support just before we must. Due to that, and due to I already have a PR ready to push open to drop 1.22 support I'd like to have that be a separate PR.

@manics
Copy link
Member

manics commented Mar 1, 2023

@consideRatio
Copy link
Member Author

If you're not dropping 1.22 immediately can you update https://github.com/jupyterhub/zero-to-jupyterhub-k8s/blob/main/docs/source/changelog.md#unreleased-breaking-changes ?

Done already!

image

I'll update it again in the next pr when we require k8s 1.23+!

@manics manics merged commit 29b041c into jupyterhub:main Mar 1, 2023
consideRatio pushed a commit to jupyterhub/helm-chart that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In March 2023 - drop support for k8s 1.21
2 participants