-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure absolute and server URL prefixes #85
Conversation
Last two commits add the changes suggested by @yuvipanda (#84 (comment)) and adds a travis test |
HTTP headers X-Forwarded-Context and X-ProxyContextPath set to /{server-name} instead of /proxy/{port} for SuperviseAndProxyHandler
Also changes the absolute proxy prefix to /proxy/absolute/
Also make this work with websockets
4675a3e
to
8e6ed7c
Compare
@manics I've made the following changes here:
This is an amazing contribution, thank you very much for it! I'll merge shortly |
@manics I'm actually going to wait for you to OK my changes before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuvipanda I'm OK with your changes, just need to fix Travis.
Am also super thankful for adding tests :) Would be nice to switch to Circle at some point though. |
This started off as a fix for the
X-Forwarded-Context
X-ProxyContextPath
. Previously they were always/proxy/{port}
, now they should be/server-name
if this is a managed server. Since this is related to the code that controls the URL rewriting I thought I'd add in support for absolute URLs.I've done some testing with:
python-http
should produce logs likepython-http-abs
should produce logs likeAlso
/proxy-abs/port
is the absolute version of/proxy/port
Needs more testing! @jacobtomlinson @psychemedia
Closes #43