-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate pod and user diagnostics #146
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
…/grafana-dashboards into pod-and-user-diagnostics
for more information, see https://pre-commit.ci
The 'home directory usage' panel in the user diagnostics dashboard is not filtering based on the selected username: ![]() This may be a little tricky because these are escaped, and could be escaped differently than the server names. Am ok with leaving that as is for now but something to flag. The only difference between the pod and user board is when multiple named servers are present. Currently I think there's no real reason to have the pod diagnostics dashboard. We should figure out a way to represent the different named servers in the user diagnostics dashboard, and not have a pod specific one. Maybe we could group by the servername label in addition to the username label for now, and move to annotations once that PR lands? |
Context
The current "User Diagnostics" dashboard is technically a "Pod Diagnostics" dashboard.
In JupyterHubs where named servers are enabled, we can have multiple singleuser servers associated with one user.
Changes
This PR separates the two use cases into
by updating PromQL to make use of the
annotation_hub_jupyter_org_username
selector of thekube_pod_annotations
metric picked up from the _build_common_annotations method of Kubespawner to allow querying on unescaped usernames. This is useful for later associating unescaped usernames with membership of user groups.Also
metricAnnotationsAllowlist
$user_name
variable that allows you to filter by unescaped jupyter username at the top of the User Diagnostics dashboard~
to regex-match namespacesResult
Pod diagnostics dashboard
User diagnostics dashboard
Questions
Closes: 2i2c-org/infrastructure#5806