Allow running dev setup without kubernetes #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Talk to kubernetes to get list of running user pods only if quotas are set. This saves a network call, and allows running locally without a kubernetes setup (for frontend dev). This does meean we lose the log value of number of other pods currently running a given repo, though. - Optionally make `kube` parameter to `Build` `None` - this works fine for FakeClient. We should abstract this out better so `Build` is abstract and `KubeBuild` is kubernetes specific, but that can come later
|
Just fixing things along the way as I try to follow the contributing guide (https://github.com/jupyterhub/binderhub/blob/master/CONTRIBUTING.md#develop-user-interface). |
|
Not for this PR, but would be nice if we could also develop the front-end without Docker 😃 |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Sep 3, 2021
jupyterhub/binderhub#1323 Merge pull request #1323 from yuvipanda/fix-fake-build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if quotas are set. This saves a network call, and allows
running locally without a kubernetes setup (for frontend dev).
This does meean we lose the log value of number of other
pods currently running a given repo, though.
kubeparameter toBuildNone- this worksfine for FakeClient. We should abstract this out better so
Buildis abstract andKubeBuildis kubernetes specific, butthat can come later