Skip to content

Commit

Permalink
Merge pull request #1914 from manics/test-oldest-python
Browse files Browse the repository at this point in the history
Require Python >= 3.10 (broken on older versions)
  • Loading branch information
minrk authored Jan 30, 2025
2 parents 2ac9124 + ec9c3c4 commit e8e336d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,8 @@ jobs:
- uses: actions/setup-python@v5
id: setup-python
with:
python-version: "3.12"
# Set this to the oldest Python version supported by BinderHub
python-version: "3.10"

- name: Cache pip
uses: actions/cache@v4
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ build-backend = "setuptools.build_meta"
[tool.black]
# target-version should be all supported versions, see
# https://github.com/psf/black/issues/751#issuecomment-473066811
target-version = ["py38", "py39", "py310", "py311"]
target-version = ["py310", "py311", "py312"]


# The default isort output conflicts with black autoformatting.
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
name="binderhub",
version=versioneer.get_version(),
cmdclass=versioneer.get_cmdclass(cmdclass),
python_requires=">=3.8",
python_requires=">=3.10",
author="Project Jupyter Contributors",
author_email="[email protected]",
license="BSD",
Expand Down

0 comments on commit e8e336d

Please sign in to comment.