Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSF jobs with multiple slots display each hostname ':' separated #229

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

jbeal-work
Copy link

@jbeal-work jbeal-work commented Jan 18, 2022

Bug description

I believe old LSF implementations used space node names where a job was submitted to multiple machines. bjobs now returns a host multiple times, seperated by a ':' if more than one slot is used on a node. This means the state_gethost no longer works on LSF when using more than one cpu.
Expected behaviour

Using more than one slot should work.
Actual behaviour

Using more than one slot does not work.
How to reproduce

Have an LSF 10.1 cluster and try and use LSF with more than one slot.
Your personal set up

LSF 10.1 on ubuntu 18.04

#228

@welcome
Copy link

welcome bot commented Jan 18, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@manics manics closed this May 4, 2022
@manics manics reopened this May 4, 2022
@manics
Copy link
Member

manics commented May 4, 2022

Closed/opened to retrigger the (hopefully fixed!) CI

@mbmilligan mbmilligan merged commit 16246d3 into jupyterhub:master Sep 7, 2022
@welcome
Copy link

welcome bot commented Sep 7, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants