Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v0.8, JupyterHub has supported "named servers." If
c.JupyterHub.allow_named_servers=True
in the hub config, servers can have names assigned to them. If this setting isFalse
then there is only one server with the name '' (empty string).For BatchSpawner to work with named servers, the port selected by
batchspawner-singleuser
must be routed to the right spawner. Right now the port is attached touser.spawner
but this is really just an alias foruser.spawners['']
. Without this fix the port value lands on the empty-string spawner and that may not be what the user wanted to happen at all.To tell the hub which spawner to attach the port information to, this PR has
batchspawner-singleuser
read the value of the environment variableJUPYTERHUB_SERVER_NAME
and send it back to the hub as part of the API call. The API is modified to consume this value and use it to attach the port to the right spawner.