Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Fix tests (jsonschema!=3.0.0a1) and update for jupyterhub 9.0.1/python3.7 #105

Merged
merged 2 commits into from
Aug 10, 2018

Conversation

rkdarst
Copy link
Contributor

@rkdarst rkdarst commented Jul 31, 2018

No description provided.

@rkdarst
Copy link
Contributor Author

rkdarst commented Aug 1, 2018

Is something going wrong with outside software? It seems that all tests are failing in all PRs, and many of them seem unrelated to the slurmspawner changes...

@rkdarst rkdarst changed the title Travis: update for jupyterhub 9.0.1 and python 3.7 Travis: Fix tests (jsonschema!=3.0.0a1) and update for jupyterhub 9.0.1/python3.7 Aug 2, 2018
@rkdarst
Copy link
Contributor Author

rkdarst commented Aug 2, 2018

This now has a fix for the breaking tests (at least pip install jsonschema==2.6.0 worked except for a timeout, now I changed to jsonschema!=3.0.0a1).

Also, python3.7 his not yet fully supported by travis - you need to specify dist=xenial which I didn't do globally yet. So it now just adds 3.7-dev to the matrix and we can fix up later.

Assuming this works, please merge soon so we can get working tests again! Also if someone can restart the test runner on existing PRs, that would be great.

@rkdarst
Copy link
Contributor Author

rkdarst commented Aug 2, 2018

All green! Let's just hope that by jsonschema==3.0.0a2 it gets fixed upstream.

The previous run with jsonschema==2.6.0 had one failure because of a timeout, btw. Otherwise green too.

@minrk minrk merged commit fa11cb1 into jupyterhub:master Aug 10, 2018
@rkdarst rkdarst deleted the travis_jh9.0.1 branch August 11, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants