Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing Guide in .rst #381

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Contributing Guide in .rst #381

merged 3 commits into from
Jul 22, 2024

Conversation

arjxn-py
Copy link
Member

Includes Contributing Guide in readthedocs while also having a converted version of CONTRIBUTING.md in .rst

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch arjxn-py/JupyterCAD/contributing-readthedocs

@arjxn-py
Copy link
Member Author

I think it should be nice to enable readthedocs build on PRs?

@arjxn-py
Copy link
Member Author

I also propose to take some inspiration from JupyterLite Contribution Guide, i'll be happy to make some changes accordingly if permitted.

@trungleduc trungleduc added the documentation Improvements or additions to documentation label Jul 19, 2024
@arjxn-py
Copy link
Member Author

Have organized media files in assets/ folder a7ee733, hoping that's alright.

@trungleduc
Copy link
Member

Thanks!

@trungleduc trungleduc merged commit 09f22d8 into jupytercad:main Jul 22, 2024
9 checks passed
@arjxn-py arjxn-py deleted the contributing-readthedocs branch July 23, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arjxn-py @trungleduc