async/await syntax #103
Merged
async/await syntax #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grab current reference as requested improves compatibility with current tornado, avoids stale handles if IOLoop changes between instantiation and starting events
requiring Python 3.6 means we can drop some old syntax and simplify things - @gen.coroutine -> async def - yield -> await - raise gen.Return(result) -> return result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requiring Python 3.6 means we can drop some old syntax and simplify things
@gen.coroutine->async defyield->awaitraise gen.Return(result)->return resultincludes #102
This shouldn't change any behavior, other than the fact that some methods can now be called in any asyncio context instead of requiring tornado.
The main consequence is when there's a bug where a coroutine is missing an
await, the given coroutine will actually not start, rather than tornado's coroutine behavior where calling a coroutine is closer to the equivalent ofasyncio.Task(coroutine()), scheduling it immediately. I think I found one such example in the tests.