Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

descriptive log for port unavailable and port-retries=0 #5136

Merged
merged 2 commits into from
Jan 7, 2020
Merged

descriptive log for port unavailable and port-retries=0 #5136

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d04b35c
descriptive log for port unavailable and port-retries=0
pallavibharadwaj Jan 4, 2020
5996cdf
descriptive log info for port in use and port-retries=0
pallavibharadwaj Jan 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions notebook/notebookapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1490,10 +1490,13 @@ def init_webapp(self):
self.http_server.listen(port, self.ip)
except socket.error as e:
if e.errno == errno.EADDRINUSE:
self.log.info(_('The port %i is already in use, trying another port.') % port)
if self.port_retries:
self.log.info(_('The port %i is already in use, trying another port.') % port)
else:
self.log.info(_('The port %i is already in use.') % port)
continue
elif e.errno in (errno.EACCES, getattr(errno, 'WSAEACCES', errno.EACCES)):
self.log.warning(_("Permission to listen on port %i denied") % port)
self.log.warning(_("Permission to listen on port %i denied.") % port)
continue
else:
raise
Expand All @@ -1502,8 +1505,12 @@ def init_webapp(self):
success = True
break
if not success:
self.log.critical(_('ERROR: the notebook server could not be started because '
if self.port_retries:
self.log.critical(_('ERROR: the notebook server could not be started because '
'no available port could be found.'))
else:
self.log.critical(_('ERROR: the notebook server could not be started because '
'port %i is not available.') % port)
self.exit(1)

@property
Expand Down