Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to integrate https://github.com/hadim/jupyter-archive to Jupyter.
Two others to JLab and
jupyter_server
will also be submitted.For now, there is nothing in this commit because I need some guidance on how to integrate the Python code into the notebook.
My idea was to create a class called
ArchiveHandler
next toFilesHandler
infiles/handlers.py
but it appears thatFilesHandler.get
is never called when downloading a file from notebook or Jlab.Instead
web.StaticFileHandler
is usedbase.handlers.AuthenticatedFileHandler.get
.Two questions:
FilesHandler
then?ArchiveHandler
? The code is here: https://github.com/hadim/jupyter-archive/blob/master/jupyter_archive/handlers.py#L45