Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress and download folder #4945

Closed
wants to merge 2 commits into from
Closed

Compress and download folder #4945

wants to merge 2 commits into from

Conversation

hadim
Copy link

@hadim hadim commented Oct 4, 2019

The goal of this PR is to integrate https://github.com/hadim/jupyter-archive to Jupyter.

Two others to JLab and jupyter_server will also be submitted.

For now, there is nothing in this commit because I need some guidance on how to integrate the Python code into the notebook.

My idea was to create a class called ArchiveHandler next to FilesHandler in files/handlers.py but it appears that FilesHandler.get is never called when downloading a file from notebook or Jlab.

Instead web.StaticFileHandler is used base.handlers.AuthenticatedFileHandler.get.

Two questions:

@hadim
Copy link
Author

hadim commented Oct 4, 2019

JLab related PR: jupyterlab/jupyterlab#7294

@hadim
Copy link
Author

hadim commented Oct 4, 2019

I am not sure I have implemented the way you guys want but this PR + the JLab PR is fully working.

@meeseeksmachine
Copy link

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/jupyter-archive-make-download-and-extract-archive-files/2363/2

@Zsailer
Copy link
Member

Zsailer commented Jun 10, 2020

Thanks, @hadim. Sorry for the long delay! This is fantastic work! Thank you for submitting the PR here with this significant amount of work.

Unfortunately, Jupyter Notebook is not really under active development anymore (see this section of the README). We're focusing on maintaining the current codebase and accepting PRs with security fixes for now.

Given the current state of the notebook repo, I would suggest we move the server-side piece of this work to Jupyter Server and discuss there. If it lands in Jupyter Server, we can help get it integrated to jupyterlab.

In the meantime, I'm going to close this PR here.

@Zsailer Zsailer closed this Jun 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants