Skip to content

Fix hidden prompt overlay button #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Carreau merged 1 commit into from
Jul 30, 2017
Merged

Fix hidden prompt overlay button #2681

Carreau merged 1 commit into from
Jul 30, 2017

Conversation

@gnestor
Copy link
Contributor

@gnestor gnestor commented Jul 24, 2017 •
edited
Loading

Closes #2590

It looks like this.collapsed is returning false and therefore this.prompt_overlay.show() is not being called: https://github.com/jupyter/notebook/blob/master/notebook/static/notebook/js/outputarea.js#L155

@gnestor gnestor mentioned this pull request Jul 24, 2017
Closed
@gnestor
Copy link
Contributor Author

gnestor commented Jul 24, 2017 •
edited
Loading

@minrk Mind taking a look at this? Just wanna make sure that this doesn't behave unexpectedly in some edge case.

@gnestor gnestor added this to the 5.1 milestone Jul 24, 2017
@gnestor gnestor requested review from minrk and takluyver July 27, 2017 01:03
@gnestor gnestor mentioned this pull request Jul 30, 2017
Closed
11 tasks
@Carreau
Copy link
Member

Carreau commented Jul 30, 2017

Let's try it to see if it has side effects.

@Carreau Carreau merged commit decb30d into jupyter:master Jul 30, 2017
@gnestor gnestor deleted the fix-prompt-overlay branch July 31, 2017 17:16
@minrk
Copy link
Member

minrk commented Aug 2, 2017

I think this is right. I saw this when I did my PR, but then forgot to investigate.

@gnestor gnestor mentioned this pull request Aug 3, 2017
Merged
@jasongrout
Copy link
Member

jasongrout commented Oct 20, 2017

FYI, this breaks the prompt_area: false argument to the output area constructor. We're seeing this in ipywidgets, where we explicitly set that to false, but now the prompt area is still shown.

For now, we'll just hardcode some css to hide the prompt area in output widgets. I think it would be enough to check this.prompt_area and if it is false, explicitly hide the prompt area as before.

CC jupyter-widgets/ipywidgets#1765

jasongrout added a commit to jasongrout/notebook that referenced this pull request Oct 20, 2017
@jasongrout
Fix the prompt_area argument of the output area constructor.
115bde2 
See jupyter#2681 (comment) and jupyter-widgets/ipywidgets#1765
@jasongrout jasongrout mentioned this pull request Oct 20, 2017
Merged
@jasongrout
Copy link
Member

jasongrout commented Oct 20, 2017

Proposed fix: #2961

@jasongrout jasongrout mentioned this pull request Oct 20, 2017
Closed
gnestor pushed a commit that referenced this pull request Oct 21, 2017
@jasongrout @gnestor
Fix the prompt_area argument of the output area constructor. (#2961)
1405693 
See #2681 (comment) and jupyter-widgets/ipywidgets#1765
gnestor pushed a commit that referenced this pull request Oct 27, 2017
@jasongrout @gnestor
Fix the prompt_area argument of the output area constructor.
bc23e28 
See #2681 (comment) and jupyter-widgets/ipywidgets#1765
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@minrk minrk Awaiting requested review from minrk

@takluyver takluyver Awaiting requested review from takluyver

Assignees

No one assigned

Labels

bug status:resolved-locked tag:Design and UX

Projects

None yet

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

Clicking left-margin to collapse output no longer works

4 participants

@gnestor @Carreau @minrk @jasongrout