Skip to content

Allow session of type other than notebook. #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minrk merged 1 commit into from
Jun 8, 2017
Merged

Allow session of type other than notebook. #2559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions notebook/static/tree/js/sessionlist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,18 @@ define([
var len = data.length;
var nb_path;
for (var i=0; i<len; i++) {
nb_path = data[i].notebook.path;
this.sessions[nb_path] = {
id: data[i].id,
kernel: {
name: data[i].kernel.name
}
};
// The classic notebook only knows about sessions for notebooks,
// but the server now knows about more general sessions for
// things like consoles.
if (data[i].type === 'notebook') {
nb_path = data[i].notebook.path;
this.sessions[nb_path] = {
id: data[i].id,
kernel: {
name: data[i].kernel.name
}
};
}
}
this.events.trigger('sessions_loaded.Dashboard', this.sessions);
};
Expand Down