Skip to content

check allow_root after calling super #2421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
takluyver merged 1 commit into from
Apr 19, 2017
Merged

check allow_root after calling super #2421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions notebook/notebookapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1388,6 +1388,8 @@ def start(self):
This method takes no arguments so all configuration and initialization
must be done prior to calling this method."""

super(NotebookApp, self).start()

if not self.allow_root:
# check if we are running as root, and abort if it's not allowed
try:
Expand All @@ -1398,8 +1400,6 @@ def start(self):
self.log.critical("Running as root is not recommended. Use --allow-root to bypass.")
self.exit(1)

super(NotebookApp, self).start()

info = self.log.info
for line in self.notebook_info().split("\n"):
info(line)
Expand Down