Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display "Click to add a cell" button as a part of notebook, not background #7565

Open
andrii-i opened this issue Jan 17, 2025 · 2 comments
Open

Comments

@andrii-i
Copy link
Contributor

andrii-i commented Jan 17, 2025

Problem

Currently "Click to add a cell" is rendered as a part of background / outer notebook area (grey in the JupyterLab light theme) under the drop shadow from the notebook / inner notebook area (white in the JupyterLab light theme).

To me it seems that the way how button is rendered in JupyterLab, as a part of notebook / inner notebook area (white in the JupyterLab light theme) is easier to read / parse. As an added bonus, this would make design language used in lab and notebook more consistent.

Notebook:
Image

JupyterLab:
Image

Proposed Solution

Render "Click to add a cell" button as a part of notebook / inner notebook area (white in the JupyterLab light theme).

In particular white space at the bottom of inner notebook area could be made larger to accommodate the button when hovering in a way that there would be no need to add / "pop-in" any artificial white space.

Image Image

It would make sense to add the same amount of white space to at the top of the notebook for visual balance.

@jtpio
Copy link
Member

jtpio commented Jan 21, 2025

Thanks @andrii-i.

Isn't rendering the button as part of the notebook going to add some artificial white space at the bottom of the notebook, to accommodate for the button when hovering?

@andrii-i
Copy link
Contributor Author

@jtpio thank you for looking into this. It would, I was thinking that white space at the bottom of inner notebook area could be made larger to accommodate the button when hovering in a way that there would be no need to add / "pop-in" any artificial white space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants