Skip to content

Commit

Permalink
Merge pull request #5021 from krinsman/master
Browse files Browse the repository at this point in the history
Fixes #5002
  • Loading branch information
takluyver authored Nov 24, 2019
2 parents 1d76105 + 765c9f7 commit f185f41
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions notebook/notebookapp.py
Original file line number Diff line number Diff line change
Expand Up @@ -1286,14 +1286,6 @@ def _notebook_dir_validate(self, proposal):
raise TraitError(trans.gettext("No such notebook dir: '%r'") % value)
return value

@observe('notebook_dir')
def _update_notebook_dir(self, change):
"""Do a bit of validation of the notebook dir."""
# setting App.notebook_dir implies setting notebook and kernel dirs as well
new = change['new']
self.config.FileContentsManager.root_dir = new
self.config.MappingKernelManager.root_dir = new

# TODO: Remove me in notebook 5.0
server_extensions = List(Unicode(), config=True,
help=(_("DEPRECATED use the nbserver_extensions dict instead"))
Expand Down

0 comments on commit f185f41

Please sign in to comment.