Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to hatch build backend #1777

Merged
merged 5 commits into from
May 16, 2022
Merged

Switch to hatch build backend #1777

merged 5 commits into from
May 16, 2022

Conversation

blink1073
Copy link
Contributor

Fixes #1776

Hatch is now part of the pypa, and offers us some niceties:

@blink1073 blink1073 merged commit ed5140b into jupyter:main May 16, 2022
@blink1073 blink1073 deleted the use-hatch branch May 16, 2022 14:51
@SylvainCorlay
Copy link
Member

Hey @blink1073 thanks for modernizing the packaging of nbconvert.

Just a small nitpick: I have a slight preference for keeping the share/jupyter/nbconvert/templates directory structure in the repository (just like with kernels in https://github.com/jupyter-xeus/xeus-python), which is more explicit about where things go.

Let me know what you think.

@blink1073
Copy link
Contributor Author

No objections from me

@maartenbreddels
Copy link
Collaborator

My latest 'standard' is to put everything that goes under the $prefix, in the 'prefix' subdir, I think it's an artifact from how flit wants it, but it makes it clear where things go without describing it explicitly.

├── prefix
│   └── etc
│       └── jupyter
│           ├── jupyter_notebook_config.d
│           │   └── foobar.json
│           └── jupyter_server_config.d
│               └── foobar.json

@SylvainCorlay
Copy link
Member

That's fine by me too. I like this explicit style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluation install fails since the recent flit migration
3 participants