Skip to content

Commit

Permalink
Fix types and add lint to automerge (#1932)
Browse files Browse the repository at this point in the history
  • Loading branch information
blink1073 authored Jan 3, 2023
1 parent 9072e36 commit 7e96fed
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 12 deletions.
10 changes: 1 addition & 9 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,6 @@ jobs:
with:
ignore_links: 'https://ipywidgets.readthedocs.io/en/latest/examples/Output'

pre_commit:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v3
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
- uses: jupyterlab/maintainer-tools/.github/actions/pre-commit@v1

test_minimum_versions:
name: Test Minimum Versions
timeout-minutes: 20
Expand Down Expand Up @@ -154,7 +146,7 @@ jobs:
if: always()
needs:
- run-tests
- pre_commit
- test_lint
- test_minimum_versions
- test_prereleases
- check_links
Expand Down
2 changes: 1 addition & 1 deletion nbconvert/filters/highlight.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def _pygments_highlight(source, output_formatter, language="ipython", metadata=N
lexer = None
if language == "ipython2":
try:
from IPython.lib.lexers import IPythonLexer # type:ignore
from IPython.lib.lexers import IPythonLexer
except ImportError:
warn("IPython lexer unavailable, falling back on Python")
language = "python"
Expand Down
2 changes: 1 addition & 1 deletion nbconvert/filters/strings.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ def ipython2python(code):
IPython code, to be transformed to pure Python
"""
try:
from IPython.core.inputtransformer2 import TransformerManager # type:ignore
from IPython.core.inputtransformer2 import TransformerManager
except ImportError:
warnings.warn(
"IPython is needed to transform IPython syntax to pure Python."
Expand Down
2 changes: 1 addition & 1 deletion nbconvert/utils/lexers.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@

warn("nbconvert.utils.lexers is deprecated as of 5.0. Use IPython.lib.lexers")

from IPython.lib.lexers import * # type:ignore # noqa
from IPython.lib.lexers import * # noqa

0 comments on commit 7e96fed

Please sign in to comment.