Minor enhancements to the fixtures #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I totally agree. In fact, I think #160 moves this fixture into the base level conftest (before I made the plugin). I think it would be work moving ws_fetch into the plugin. |
|
I have moved |
echarles
force-pushed
the
pytest_fixture_updates
branch
from
66833fb to
0d67d5d
Compare
Zsailer
approved these changes
Feb 4, 2020
Zsailer
reviewed
Feb 4, 2020
|
LGTM! Thanks, @echarles! |
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
…ixture_updates Minor enhancements to the fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the tests, I found a few minor enhancements like removing the param from base_url fixture and adding doc to app fixture.\
I may push in the coming day more minore udpates.
My understanding is that only the fixtures defined in
pytest_plugin.pyare usable in other projects (like nbclassic). Then, how do we decide which fixture to expose? e.g. I can see a use ofws_fetchdefined intest_api.pyin kernel related projects but today this is not possible.