-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding cwd param to terminal api endpoint #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @qntnrbns! Let a few comments inline.
Great work writing the tests @qntnrbns! Thanks for working on that. I'm not sure why the Windows tests are hanging. I'll try to look into this later today. Before that, I'm putting together a minor release (0.2.0) today—if your PR doesn't get in for that... we'll put a patch release out right after with this PR 🎉 |
@Zsailer were you able to fix the windows build? |
@qntnrbns We likely need to make these tests conditional on the running platform. The same terminal params that work on Linux/MacOS won't work on Windows. There are two options for this PR:
I'm fine with either choice at this point. Note that we've ripped out the |
I took a shot at it, but I don't have a windows machine |
Given that terminado itself skips all but the basic tests on Windows due to timeouts, I think it is fair to just verify that we can submit the kwargs on Windows and not wait for a response. |
I am trying to fix this issue jupyterlab/jupyterlab#1366 in jupyterlab so that terminals open in the current working directory.
I am bumping the version of
terminado
to 0.8.3 to capture jupyter/terminado#70, and adding a json param to the terminal creation endpoint.I want to write a test for this, but could use some guidance w.r.t. the new test suite and how much we need to mock the creation of the terminal