Keep "--existing" kernel alive on Ctrl-D exit #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exiting from
jupyter-console --existing
by pressing Ctrl-D, the expected behavior is that the existing kernel is left alive. See #48 for a discussion. (This might be related to #126, too.)Currently, however, the kernel is shut down upon console exit. This commit fixes this.
Apparently, setting
self.keepkernel = True
affects only the Ctrl-D behavior. Theexit
command still haskeep_kernel=False
by default.Before:
jupyter-console
jupyter-console --existing
exit
exit(keep_kernel=True)
After:
jupyter-console
jupyter-console --existing
exit
exit(keep_kernel=True)