Update execution_count before running cell #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the execution count displayed next to the code is correct by processing any IOPub messages between pressing enter and running the code. The execution count should always be updated after an execute_input message even if the message came from a session whose output wouldn't be included because it is still the execution count of this session's kernel.
|
Any thoughts on why this is failing? I don't see any difference with or without this change when I run the test commands manually. Also, it looks like it's only failing for Python 3.6 which is odd. |
|
I reran the failing test and it passed; I think it was just a random failure. This looks reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures the execution count displayed next to code is correct even if the execution count has been updated in another session talking to the same kernel.