retry kernel_info_requests in wait_for_ready #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fill out some reasoning in the description? Thanks! |
|
Related to #593. While this doesn't truly solve the issue, it slightly increases the likelihood of iopub being fully connected and subscribed for that first message. |
|
I was going to describe this a bit more, but I just opened this so that this change is somewhere for reference. |
SylvainCorlay
force-pushed
the
iopub-first
branch
from
7631ed0
to
6d41ead
Compare
SylvainCorlay
force-pushed
the
iopub-first
branch
3 times, most recently
from
885620a
to
7a063dc
Compare
jasongrout
reviewed
Dec 9, 2020
SylvainCorlay
force-pushed
the
iopub-first
branch
2 times, most recently
from
c983275
to
7d3cdce
Compare
SylvainCorlay
force-pushed
the
iopub-first
branch
from
7d3cdce
to
06a32c4
Compare
|
This is ready to go @minrk. I had to change the test to check for parent id of responses because there may be older kernel info replies coming late to the party. Now looking into |
minrk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the logic of
wait_for_readyto continue sending info request until there is some IOPub message as a response.